You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/01/14 17:50:20 UTC
Review Request 42309: Fallback to --git-dir when --git-common-dir not
available.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Repository: mesos
Description
-------
The newly introduced way of finding the .git directory via
--git-common-dir is only supported on newer versions of git. Fallback to
the older --git-dir method if --git-common-dir is not supported.
Diffs
-----
bootstrap 519090d696ae09dac70318e91ade583b38f44048
support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
Diff: https://reviews.apache.org/r/42309/diff/
Testing
-------
Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
Thanks,
Kevin Klues
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 14, 2016, 5:26 p.m., haosdent huang wrote:
> > support/post-reviews.py, line 98
> > <https://reviews.apache.org/r/42309/diff/1/?file=1196966#file1196966line98>
> >
> > Pull to else seems would be better?
>
> Kevin Klues wrote:
> I'm sorry, I don't understand your comment. I need to first try the call with "--git-common-dir" and if it fails (by simply returning "--git-common-dir" back to me, then I need to fallback to calling with "--git-dir". I wanted to just check the exit code if it failed, but it actually reurns 0 in all cases.
Sorry, I got your idea. If git don't support `--git-common-dir`, it would return `--git-common-dir` in result.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114502
-----------------------------------------------------------
On Jan. 14, 2016, 4:50 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 4:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Kevin Klues <kl...@gmail.com>.
> On Jan. 14, 2016, 5:26 p.m., haosdent huang wrote:
> > support/post-reviews.py, line 98
> > <https://reviews.apache.org/r/42309/diff/1/?file=1196966#file1196966line98>
> >
> > Pull to else seems would be better?
I'm sorry, I don't understand your comment. I need to first try the call with "--git-common-dir" and if it fails (by simply returning "--git-common-dir" back to me, then I need to fallback to calling with "--git-dir". I wanted to just check the exit code if it failed, but it actually reurns 0 in all cases.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114502
-----------------------------------------------------------
On Jan. 14, 2016, 4:50 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 4:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114502
-----------------------------------------------------------
support/post-reviews.py (line 98)
<https://reviews.apache.org/r/42309/#comment175355>
Pull to else seems would be better?
- haosdent huang
On Jan. 14, 2016, 4:50 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 4:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114517
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Jan. 14, 2016, 5:56 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 5:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114526
-----------------------------------------------------------
bootstrap (line 35)
<https://reviews.apache.org/r/42309/#comment175374>
nit pick: `s/^the/The/`
bootstrap (line 37)
<https://reviews.apache.org/r/42309/#comment175375>
As a weird corner case this makes it impossible to use `--git-common-dir` as name of the git common directory. I believe e.g., something like checking if `$_gitdir` existed would have worked at least as well for us.
Also, I think this looks weird enough to justify a comment explaining why we do this.
support/post-reviews.py (line 99)
<https://reviews.apache.org/r/42309/#comment175376>
Same issues here as in `bootstrap`.
- Benjamin Bannier
On Jan. 14, 2016, 6:56 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 6:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114629
-----------------------------------------------------------
Ship it!
Thanks for promptly following up on this issue, Kevin!
support/post-reviews.py (line 111)
<https://reviews.apache.org/r/42309/#comment175484>
Minor nit, missing '.' - fixing this while committing.
- Till Toenshoff
On Jan. 15, 2016, 1:04 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 1:04 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-4374
> https://issues.apache.org/jira/browse/MESOS-4374
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 1:04 a.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Add comment about why we even need to use --git-common-dir instead of just --git-dir
Bugs: MESOS-4374
https://issues.apache.org/jira/browse/MESOS-4374
Repository: mesos
Description
-------
The newly introduced way of finding the .git directory via
--git-common-dir is only supported on newer versions of git. Fallback to
the older --git-dir method if --git-common-dir is not supported.
Diffs (updated)
-----
bootstrap 519090d696ae09dac70318e91ade583b38f44048
support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
Diff: https://reviews.apache.org/r/42309/diff/
Testing
-------
Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
Thanks,
Kevin Klues
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114553
-----------------------------------------------------------
Ship it!
Tested with git-2.7.0 (OS X 10.10.5) and git-2.1.4 (Debian8).
- Benjamin Bannier
On Jan. 14, 2016, 8:56 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 8:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-4374
> https://issues.apache.org/jira/browse/MESOS-4374
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/#review114575
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42309]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 14, 2016, 7:56 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42309/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 7:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-4374
> https://issues.apache.org/jira/browse/MESOS-4374
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The newly introduced way of finding the .git directory via
> --git-common-dir is only supported on newer versions of git. Fallback to
> the older --git-dir method if --git-common-dir is not supported.
>
>
> Diffs
> -----
>
> bootstrap 519090d696ae09dac70318e91ade583b38f44048
> support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
>
> Diff: https://reviews.apache.org/r/42309/diff/
>
>
> Testing
> -------
>
> Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 7:56 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Address Benjamin Bannier's comments.
Bugs: MESOS-4374
https://issues.apache.org/jira/browse/MESOS-4374
Repository: mesos
Description
-------
The newly introduced way of finding the .git directory via
--git-common-dir is only supported on newer versions of git. Fallback to
the older --git-dir method if --git-common-dir is not supported.
Diffs (updated)
-----
bootstrap 519090d696ae09dac70318e91ade583b38f44048
support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
Diff: https://reviews.apache.org/r/42309/diff/
Testing
-------
Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
Thanks,
Kevin Klues
Re: Review Request 42309: Fallback to --git-dir when --git-common-dir
not available.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 5:56 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Simplify the logic in bootstrap to match that in post-reviews.py
Repository: mesos
Description
-------
The newly introduced way of finding the .git directory via
--git-common-dir is only supported on newer versions of git. Fallback to
the older --git-dir method if --git-common-dir is not supported.
Diffs (updated)
-----
bootstrap 519090d696ae09dac70318e91ade583b38f44048
support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44
Diff: https://reviews.apache.org/r/42309/diff/
Testing
-------
Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively.
Thanks,
Kevin Klues