[GitHub] [netbeans] zimmi opened a new pull request #1548: [NETBEANS-1396] [WIP] Missing code completion and Javadocs in maven projects with classifier

[GitBox <gi...@apache.org>]

zimmi opened a new pull request #1548: [NETBEANS-1396] [WIP] Missing code completion and Javadocs in maven projects with classifier
URL: https://github.com/apache/netbeans/pull/1548
 
 
    This partially solves [NETBEANS-1396](https://issues.apache.org/jira/projects/NETBEANS/issues/NETBEANS-1396) and [NETBEANS-2197](https://issues.apache.org/jira/browse/NETBEANS-2197) (duplicate?) by falling back to the main javadoc jar if there is none associated with the one with the classifier (example: fall back to `javafx-graphics-13-javadoc.jar` if there is no `javafx-graphics-13-linux-javadoc.jar`).
   
   The javadoc layout of OpenJFX differs from the default output of the maven-javadoc-plugin, so NetBeans now also tries to find the correct .html file in that case. This also enhances the javadoc parser to understand the output of javadoc 11.
   
   I'd like to have some feedback on the approach before I do the same for attached sources. Doing that should be easier™ because the layout of OpenJFX seems to be standard in this case.
   
   And a question: I found that most test cases don't work because the test resources are missing, e.g. `HTMLJavadocParserTest::testGetJavadocText` in the `java.sourceui`module tries to find a non-existent `HTMLJavadocParser.html`. Will those be added back? Changing the code feels a bit like flying blind without the tests.
   
   To link the discussions together: https://github.com/openjfx/openjfx-docs/issues/44, https://github.com/openjfx/javadoc/issues/6 and [a stackoverflow question](https://stackoverflow.com/questions/54278159/javafx-11-in-netbeans-10-with-maven-has-no-sources-javadocs).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists