[GitHub] [shardingsphere] I-Love-China commented on a diff in pull request #21207: Fix max-connections-size-per-query in transaction(#21099)

[GitBox <gi...@apache.org>]

I-Love-China commented on code in PR #21207:
URL: https://github.com/apache/shardingsphere/pull/21207#discussion_r1004447873


##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java:
##########
@@ -307,7 +307,9 @@ private ResultSet executeFederationQuery(final QueryContext queryContext) throws
     }
     
     private DriverExecutionPrepareEngine<JDBCExecutionUnit, Connection> createDriverExecutionPrepareEngine() {
-        int maxConnectionsSizePerQuery = metaDataContexts.getMetaData().getProps().<Integer>getValue(ConfigurationPropertyKey.MAX_CONNECTIONS_SIZE_PER_QUERY);
+        int maxConnectionsSizePerQuery = connection.isHoldTransaction()

Review Comment:
   > Did you consider the possible extra memory usage when maxConnectionsSizePerQuery = 1?
   
   Correctness is the most fundamental requirement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org