[jira] [Commented] (CAMEL-14209) The File component should be able to include the `doneFile` as well

["Claus Ibsen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980356#comment-16980356 ] 

Claus Ibsen commented on CAMEL-14209:
-------------------------------------

So you are doing a from file to s3 and in the file directory you are using doneFile option, and want to sync that file as well to s3, even if such a file is an empty marker file?

Yeah sure you are welcome to work on a PR and include an unit test (just mind unit tests goes into camel-core) as file used to be in camel-core for camel 2.x

> The File component should be able to include the `doneFile` as well
> -------------------------------------------------------------------
>
>                 Key: CAMEL-14209
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14209
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 3.0.0-M3
>            Reporter: Vilmos Nagy
>            Priority: Trivial
>
> I want to sync the files from a directory to an S3 bucket - in case there's a {{doneFile}} in the directory. It's an easy job with the {{file}} component and with the {{aggregator}}.
> But I do want to include the {{doneFile}} as well.
> As far as I understand it's easy to implement a new query parameter to the file component ({{includeDoneFile}}) and modify the {{GenericFileConsumer}} accordingly (around the 660. line):
> {code:java}
>             if (endpoint.isDoneFile(file.getFileNameOnly()) && !endpoint.isIncludeDoneFile()) {
>                 log.trace("Skipping done file: {}", file);
>                 return false;
>             }
> {code}
> Would you accept a PR with this change?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)