You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/23 13:46:21 UTC

[GitHub] [rocketmq] xijiu opened a new pull request #3672: Improve the test cases of the tools module

xijiu opened a new pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Improve the test cases of the tools module
   
   ## Brief changelog
   
   test cases of the tools module
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1001350645


   @xijiu LGTM, and I will check the reason why the code coverage decreased so much, thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] xijiu commented on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
xijiu commented on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1001822208


   > Good catch. One day, I finally see we have removed the skip test tag in this module. Thanks, BTW, would you like to help to opt the Integration Test in RocketMQ:-)
   
   
   Sure, it's my pleasure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1000895256


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3672](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a073ffd) into [develop](https://codecov.io/gh/apache/rocketmq/commit/75557b8700bef395002a6b5b7c2bb083c120b632?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75557b8) will **decrease** coverage by `2.37%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3672/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3672      +/-   ##
   =============================================
   - Coverage      49.66%   47.28%   -2.38%     
   - Complexity      4722     5029     +307     
   =============================================
     Files            555      627      +72     
     Lines          36837    41340    +4503     
     Branches        4856     5370     +514     
   =============================================
   + Hits           18294    19549    +1255     
   - Misses         16239    19361    +3122     
   - Partials        2304     2430     +126     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | [...sumer/rebalance/AllocateMessageQueueAveragely.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvcmViYWxhbmNlL0FsbG9jYXRlTWVzc2FnZVF1ZXVlQXZlcmFnZWx5LmphdmE=) | `56.52% <0.00%> (-4.35%)` | :arrow_down: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `58.11% <0.00%> (-1.71%)` | :arrow_down: |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | :arrow_down: |
   | [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `64.39% <0.00%> (-0.32%)` | :arrow_down: |
   | [.../tools/command/message/DecodeMessageIdCommond.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWVzc2FnZS9EZWNvZGVNZXNzYWdlSWRDb21tb25kLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...tmq/tools/command/topic/TopicStatusSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvdG9waWMvVG9waWNTdGF0dXNTdWJDb21tYW5kLmphdmE=) | `19.35% <0.00%> (ø)` | |
   | [...s/command/broker/UpdateBrokerConfigSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL1VwZGF0ZUJyb2tlckNvbmZpZ1N1YkNvbW1hbmQuamF2YQ==) | `58.69% <0.00%> (ø)` | |
   | [...tools/command/offset/GetConsumerStatusCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvb2Zmc2V0L0dldENvbnN1bWVyU3RhdHVzQ29tbWFuZC5qYXZh) | `60.97% <0.00%> (ø)` | |
   | [...ols/command/consumer/UpdateSubGroupSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29uc3VtZXIvVXBkYXRlU3ViR3JvdXBTdWJDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [74 more](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75557b8...a073ffd](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] xijiu commented on a change in pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
xijiu commented on a change in pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#discussion_r775302150



##########
File path: tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java
##########
@@ -99,4 +69,30 @@ public void testExecute() throws SubCommandException {
             ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs, cmd.buildCommandlineOptions(options), new PosixParser());
         cmd.execute(commandLine, options, null);
     }
+
+    private ServerResponseMocker startNameServer() {

Review comment:
       @duhenglucky   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3672: Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1000327295


   
   [![Coverage Status](https://coveralls.io/builds/45230941/badge)](https://coveralls.io/builds/45230941)
   
   Coverage decreased (-3.0%) to 53.178% when pulling **fb7dcbeb5c3f9570475773f7a4e50d0e3984c35e on xijiu:improving_tools_junit_test** into **f1b2c4f360fdac3c4205d7275f389c4dbff44748 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling removed a comment on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
vongosling removed a comment on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1001816408


   Good catch ~ Would you like to help to opt the Integration Test in RocketMQ:-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling edited a comment on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1001816408


   Good catch ~ Would you like to help to opt the Integration Test in RocketMQ:-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #3672: Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1000895256


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3672](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb7dcbe) into [develop](https://codecov.io/gh/apache/rocketmq/commit/f1b2c4f360fdac3c4205d7275f389c4dbff44748?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1b2c4f) will **decrease** coverage by `2.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3672/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3672      +/-   ##
   =============================================
   - Coverage      49.65%   47.19%   -2.46%     
   - Complexity      4722     5018     +296     
   =============================================
     Files            555      627      +72     
     Lines          36837    41340    +4503     
     Branches        4856     5370     +514     
   =============================================
   + Hits           18291    19512    +1221     
   - Misses         16242    19403    +3161     
   - Partials        2304     2425     +121     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `59.13% <0.00%> (-2.16%)` | :arrow_down: |
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `67.82% <0.00%> (-0.18%)` | :arrow_down: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (ø)` | |
   | [...mq/tools/command/export/ExportMetadataCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvZXhwb3J0L0V4cG9ydE1ldGFkYXRhQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/rocketmq/tools/monitor/FailedMsgs.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL21vbml0b3IvRmFpbGVkTXNncy5qYXZh) | `63.63% <0.00%> (ø)` | |
   | [...tools/command/offset/GetConsumerStatusCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvb2Zmc2V0L0dldENvbnN1bWVyU3RhdHVzQ29tbWFuZC5qYXZh) | `60.97% <0.00%> (ø)` | |
   | [...tmq/tools/command/export/ExportConfigsCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvZXhwb3J0L0V4cG9ydENvbmZpZ3NDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ketmq/tools/command/topic/TopicListSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvdG9waWMvVG9waWNMaXN0U3ViQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [70 more](https://codecov.io/gh/apache/rocketmq/pull/3672/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b2c4f...fb7dcbe](https://codecov.io/gh/apache/rocketmq/pull/3672?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on a change in pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on a change in pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#discussion_r775238681



##########
File path: tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java
##########
@@ -99,4 +69,30 @@ public void testExecute() throws SubCommandException {
             ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs, cmd.buildCommandlineOptions(options), new PosixParser());
         cmd.execute(commandLine, options, null);
     }
+
+    private ServerResponseMocker startNameServer() {

Review comment:
       there's so many startNameServer() method that exists in multiple classes， So how about putting the mock to the nameserver in the same test tool class to avoid so much duplication code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1000327295


   
   [![Coverage Status](https://coveralls.io/builds/45240529/badge)](https://coveralls.io/builds/45240529)
   
   Coverage decreased (-2.9%) to 53.283% when pulling **a073ffd3d03d1a6252ae590ecb7f115622aae795 on xijiu:improving_tools_junit_test** into **75557b8700bef395002a6b5b7c2bb083c120b632 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling commented on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1001816937


   Good catch. One day, I finally see we have removed the skip test tag in this module. Thanks, BTW, would you like to help to opt the Integration Test in RocketMQ:-)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling commented on pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1001816408


   Good catch ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3672: Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#issuecomment-1000327295


   
   [![Coverage Status](https://coveralls.io/builds/45213454/badge)](https://coveralls.io/builds/45213454)
   
   Coverage decreased (-2.9%) to 53.266% when pulling **b19d9baf3ec1035e503c292e28ff11e03a37f16d on xijiu:improving_tools_junit_test** into **f1b2c4f360fdac3c4205d7275f389c4dbff44748 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] xijiu commented on a change in pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

Posted by GitBox <gi...@apache.org>.
xijiu commented on a change in pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#discussion_r775243608



##########
File path: tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java
##########
@@ -99,4 +69,30 @@ public void testExecute() throws SubCommandException {
             ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs, cmd.buildCommandlineOptions(options), new PosixParser());
         cmd.execute(commandLine, options, null);
     }
+
+    private ServerResponseMocker startNameServer() {

Review comment:
       When coding, I also realized that the code repetition of startNameServer() is relatively high. I wanted to retain the flexibility of this method.
   
   However, in most scenarios, startNameServer() can indeed use the default configuration. I will extract a NameServer of the default type, If other test cases have specific requirements, rewrite their own logic 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org