[jira] [Commented] (THRIFT-2859) JSON generator: output complete descriptors

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226441#comment-14226441 ] 

ASF GitHub Bot commented on THRIFT-2859:
----------------------------------------

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/290

    JSON generator: output complete descriptors

    The attached pull request contains some improvements to the JSON generator:
    1. programs are no longer merged by default, use "--gen json:merge"
    2. "index" is renamed to "key" for fields to match the compiler's internal naming
    3. types are described in a way that does not require string parsing
    4. full support for exceptions, unions, namespaces, includes and required/optional fields
    
    Jira: THRIFT-2859


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift THRIFT-2859

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
    
----
commit f111a95b177697b5a661a6de858d34521e352ada
Author: Stig Bakken <st...@zedge.net>
Date:   2014-10-31T08:04:14Z

    Add --gen json:merge option, and disable merging by default

commit 83109883d73d287a74a6b2a9800b6b299983ba40
Author: Stig Bakken <st...@zedge.net>
Date:   2014-11-03T08:08:21Z

    JSON generator: output complete descriptors

----


> JSON generator: output complete descriptors
> -------------------------------------------
>
>                 Key: THRIFT-2859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2859
>             Project: Thrift
>          Issue Type: Improvement
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Priority: Minor
>
> (Someone should probably add a Jira component for the JSON generator.)
> The attached pull request contains some improvements to the JSON generator:
> 1. programs are no longer merged by default, use "--gen json:merge"
> 2. "index" is renamed to "key" for fields to match the compiler's internal naming
> 3. types are described in a way that does not require string parsing
> 4. full support for exceptions, unions, namespaces, includes and required/optional fields



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)