You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lfrancke (via GitHub)" <gi...@apache.org> on 2025/08/13 15:34:29 UTC
[PR] NIFI-14858: Make SNI checking configurable [nifi]
lfrancke opened a new pull request, #10201:
URL: https://github.com/apache/nifi/pull/10201
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
Introduces two new properties:
- nifi.web.https.sni.required
- nifi.web.https.sni.host.check
[NIFI-14858](https://issues.apache.org/jira/browse/NIFI-14858)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "lfrancke (via GitHub)" <gi...@apache.org>.
lfrancke commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3185113575
The new issue for the contrib-check failures: https://issues.apache.org/jira/browse/NIFI-14859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "lfrancke (via GitHub)" <gi...@apache.org>.
lfrancke commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184577332
Running the command leads to various failures:
```
[WARNING] PMD Failure: org.apache.nifi.web.search.attributematchers.ConnectivityMatcherTest:38 Rule:MissingOverride Priority:3 The method 'setUp()' is missing an @Override annotation..
[WARNING] PMD Failure: org.apache.nifi.web.search.attributematchers.ParameterMatcherTest:35 Rule:MissingOverride Priority:3 The method 'setUp()' is missing an @Override annotation..
[WARNING] PMD Failure: org.apache.nifi.web.search.attributematchers.PrioritiesMatcherTest:40 Rule:MissingOverride Priority:3 The method 'setUp()' is missing an @Override annotation..
[WARNING] PMD Failure: org.apache.nifi.web.search.attributematchers.ProcessGroupMatcherTest:33 Rule:MissingOverride Priority:3 The method 'setUp()' is missing an @Override annotation..
[...]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.27.0:check (check) on project nifi-web-api: PMD 7.16.0 has found 4 violations. For more details see: /home/lars/dev/external/nifi/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/pmd.xml -> [Help 1]
```
I'm not sure how this ever worked for anyone recently? No one could have run the contrib checks successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184767511
@lfrancke I am the one who introduced that PMD rule although when I build, I am not encountering those error messages. Can you please share what environment you are building in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "lfrancke (via GitHub)" <gi...@apache.org>.
lfrancke commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184832863
Thanks @dan-s1
I'm on Linux and just on the main branch (including this patch) and all I did was to run `./mvnw clean install -P contrib-check` and then am running into these errors.
```
❯ git status
On branch NIFI-14858
Your branch is up to date with 'lars/NIFI-14858'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: nifi-extension-bundles/nifi-extension-utils/nifi-syslog-utils/src/test/java/org/apache/nifi/syslog/StrictSyslog5424ParserDashPolicyTest.java
modified: nifi-extension-bundles/nifi-extension-utils/nifi-syslog-utils/src/test/java/org/apache/nifi/syslog/StrictSyslog5424ParserNullPolicyTest.java
modified: nifi-extension-bundles/nifi-extension-utils/nifi-syslog-utils/src/test/java/org/apache/nifi/syslog/StrictSyslog5424ParserOmitPolicyTest.java
modified: nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/ConnectivityMatcherTest.java
modified: nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/ParameterMatcherTest.java
modified: nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/PrioritiesMatcherTest.java
modified: nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/ProcessGroupMatcherTest.java
no changes added to commit (use "git add" and/or "git commit -a")
```
These changed files are me adding the `@Override` annotations that PMD complains about. No other changes except the ones from this PR.
```
❯ java --version
openjdk 21.0.8 2025-07-15
OpenJDK Runtime Environment (build 21.0.8+9)
OpenJDK 64-Bit Server VM (build 21.0.8+9, mixed mode, sharing)
```
Let me know if I should try anything else.
Otherwise I had planned on just submitting a patch tomorrow to fix all these warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184860630
Can we please get this into its own JIRA/PR thread (this being the build issues oyu're seeing).
We have constant CI builds that aren't apparently hitting this so it isn't clear that the fix will show what the problem was in the first place...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184876664
It absolutely does get run.
https://github.com/apache/nifi/blob/main/.github/workflows/code-compliance.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #10201: NIFI-14858: Make SNI checking configurable
URL: https://github.com/apache/nifi/pull/10201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184857036
@lfrancke Honestly I am not sure why I do not have this violation as I am running in a similar environment. I suggest if the PMD changes have nothing to do with your own PR changes then you should create a new Jira ticket to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14858: Make SNI checking configurable [nifi]
Posted by "lfrancke (via GitHub)" <gi...@apache.org>.
lfrancke commented on PR #10201:
URL: https://github.com/apache/nifi/pull/10201#issuecomment-3184864852
FWIW this only happens with the contrib-check profile. I assume that's not part of CI. I'll open a new issue for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org