You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/23 10:57:42 UTC
[GitHub] [geode] alb3rtobr opened a new pull request #6372: GEODE-4709: Add list gateways output sample in UG
alb3rtobr opened a new pull request #6372:
URL: https://github.com/apache/geode/pull/6372
`list gateways` command had no output example in the documentation. This PR also fixes other formatting errors in the `list.html.md.erb` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on a change in pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #6372:
URL: https://github.com/apache/geode/pull/6372#discussion_r621534545
##########
File path: geode-docs/topologies_and_comm/multi_site_configuration/setting_up_a_multisite_system.html.md.erb
##########
@@ -310,81 +310,79 @@ As an example, assume the following scenario:
You can then execute the following in gfsh to see the effects of rebalancing:
- gfsh -e "connect --locator=localhost[10331]" -e "list gateways"
- ...
- (2) Executing - list gateways
-
- Gateways
-
- GatewaySender
+``` pre
+gfsh -e "connect --locator=localhost[10331]" -e "list gateways"
+...
+(2) Executing - list gateways
- GatewaySender Id | Member | Remote Cluster Id | Type | Status | Queued Events | Receiver Location
- ---------------- | --------------------------------- | ----------------- | -------- | ------- | ------------- | -----------------
- ln | boglesbymac(ny-1:88641)<v2>:33491 | 2 | Parallel | Running | 0 | boglesbymac:5037
- ln | boglesbymac(ny-2:88705)<v3>:29329 | 2 | Parallel | Running | 0 | boglesbymac:5064
- ln | boglesbymac(ny-3:88715)<v4>:36808 | 2 | Parallel | Running | 0 | boglesbymac:5132
- ln | boglesbymac(ny-4:88724)<v5>:52993 | 2 | Parallel | Running | 0 | boglesbymac:5324
+GatewaySender Section
- GatewayReceiver
+GatewaySender Id | Member | Remote Cluster Id | Type | Status | Queued Events | Receiver Location
+---------------- | --------------------------------- | ----------------- | -------- | ------- | ------------- | -----------------
+ln | mymac(ny-1:88641)<v2>:33491 | 2 | Parallel | Running | 0 | mymac:5037
+ln | mymac(ny-2:88705)<v3>:29329 | 2 | Parallel | Running | 0 | mymac:5064
+ln | mymac(ny-3:88715)<v4>:36808 | 2 | Parallel | Running | 0 | mymac:5132
+ln | mymac(ny-4:88724)<v5>:52993 | 2 | Parallel | Running | 0 | mymac:5324
- Member | Port | Sender Count | Sender's Connected
- --------------------------------- | ---- | ------------ | --------------------------------------------------------------------------
- boglesbymac(ny-1:88641)<v2>:33491 | 5057 | 24 | ["boglesbymac(ln-1:88651)<v2>:48277","boglesbymac(ln-4:88681)<v5>:42784","boglesbymac(ln-2:88662)<v3>:12796","boglesbymac(ln-3:88672)<v4>:43675"]
- boglesbymac(ny-2:88705)<v3>:29329 | 5082 | 0 | []
- boglesbymac(ny-3:88715)<v4>:36808 | 5371 | 0 | []
- boglesbymac(ny-4:88724)<v5>:52993 | 5247 | 0 | []
+GatewayReceiver Section
+ Member | Port | Sender Count | Senders Connected
+--------------------------------- | ---- | ------------ | --------------------------------------------------------------------------
+mymac(ny-1:88641)<v2>:33491 | 5057 | 24 | ["mymac(ln-1:88651)<v2>:48277","mymac(ln-4:88681)<v5>:42784","mymac(ln-2:88662)<v3>:12796","mymac(ln-3:88672)<v4>:43675"]
+mymac(ny-2:88705)<v3>:29329 | 5082 | 0 | []
+mymac(ny-3:88715)<v4>:36808 | 5371 | 0 | []
+mymac(ny-4:88724)<v5>:52993 | 5247 | 0 | []
+```
Execute the load-balance command:
+``` pre
Review comment:
Done, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6372:
URL: https://github.com/apache/geode/pull/6372#issuecomment-827120029
> * Output of the `list gateways` command shows a heading "Sender's Connected".
> The apostrophe is out of place and should be deleted: "Senders Connected". I understand this entails a code change.
Good catch! I have verified that this typo was already changed in the code, but not in the user guide. Apart from your suggested changes in `list.html.md.erb`, my last commit also modifies `setting_up_a_multisite_system.html.md.erb` to update the `list gateways` command output. I also changed the contributor's name that was present in the output as you did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6372:
URL: https://github.com/apache/geode/pull/6372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #6372:
URL: https://github.com/apache/geode/pull/6372#issuecomment-827834468
@alb3rtobr fyi if you had created your PR with the "allow edits from maintainers" box checked, Dave or I could fix small things like this missing blank line and save some back-and-forth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6372:
URL: https://github.com/apache/geode/pull/6372#discussion_r621459621
##########
File path: geode-docs/topologies_and_comm/multi_site_configuration/setting_up_a_multisite_system.html.md.erb
##########
@@ -310,81 +310,79 @@ As an example, assume the following scenario:
You can then execute the following in gfsh to see the effects of rebalancing:
- gfsh -e "connect --locator=localhost[10331]" -e "list gateways"
- ...
- (2) Executing - list gateways
-
- Gateways
-
- GatewaySender
+``` pre
+gfsh -e "connect --locator=localhost[10331]" -e "list gateways"
+...
+(2) Executing - list gateways
- GatewaySender Id | Member | Remote Cluster Id | Type | Status | Queued Events | Receiver Location
- ---------------- | --------------------------------- | ----------------- | -------- | ------- | ------------- | -----------------
- ln | boglesbymac(ny-1:88641)<v2>:33491 | 2 | Parallel | Running | 0 | boglesbymac:5037
- ln | boglesbymac(ny-2:88705)<v3>:29329 | 2 | Parallel | Running | 0 | boglesbymac:5064
- ln | boglesbymac(ny-3:88715)<v4>:36808 | 2 | Parallel | Running | 0 | boglesbymac:5132
- ln | boglesbymac(ny-4:88724)<v5>:52993 | 2 | Parallel | Running | 0 | boglesbymac:5324
+GatewaySender Section
- GatewayReceiver
+GatewaySender Id | Member | Remote Cluster Id | Type | Status | Queued Events | Receiver Location
+---------------- | --------------------------------- | ----------------- | -------- | ------- | ------------- | -----------------
+ln | mymac(ny-1:88641)<v2>:33491 | 2 | Parallel | Running | 0 | mymac:5037
+ln | mymac(ny-2:88705)<v3>:29329 | 2 | Parallel | Running | 0 | mymac:5064
+ln | mymac(ny-3:88715)<v4>:36808 | 2 | Parallel | Running | 0 | mymac:5132
+ln | mymac(ny-4:88724)<v5>:52993 | 2 | Parallel | Running | 0 | mymac:5324
- Member | Port | Sender Count | Sender's Connected
- --------------------------------- | ---- | ------------ | --------------------------------------------------------------------------
- boglesbymac(ny-1:88641)<v2>:33491 | 5057 | 24 | ["boglesbymac(ln-1:88651)<v2>:48277","boglesbymac(ln-4:88681)<v5>:42784","boglesbymac(ln-2:88662)<v3>:12796","boglesbymac(ln-3:88672)<v4>:43675"]
- boglesbymac(ny-2:88705)<v3>:29329 | 5082 | 0 | []
- boglesbymac(ny-3:88715)<v4>:36808 | 5371 | 0 | []
- boglesbymac(ny-4:88724)<v5>:52993 | 5247 | 0 | []
+GatewayReceiver Section
+ Member | Port | Sender Count | Senders Connected
+--------------------------------- | ---- | ------------ | --------------------------------------------------------------------------
+mymac(ny-1:88641)<v2>:33491 | 5057 | 24 | ["mymac(ln-1:88651)<v2>:48277","mymac(ln-4:88681)<v5>:42784","mymac(ln-2:88662)<v3>:12796","mymac(ln-3:88672)<v4>:43675"]
+mymac(ny-2:88705)<v3>:29329 | 5082 | 0 | []
+mymac(ny-3:88715)<v4>:36808 | 5371 | 0 | []
+mymac(ny-4:88724)<v5>:52993 | 5247 | 0 | []
+```
Execute the load-balance command:
+``` pre
Review comment:
One format correction: please insert a blank line following "Execute the load-balance command:" so Markdown will properly recognize the first line of the example code. Thanks! (I verified this change in my local copy.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6372:
URL: https://github.com/apache/geode/pull/6372#discussion_r621459621
##########
File path: geode-docs/topologies_and_comm/multi_site_configuration/setting_up_a_multisite_system.html.md.erb
##########
@@ -310,81 +310,79 @@ As an example, assume the following scenario:
You can then execute the following in gfsh to see the effects of rebalancing:
- gfsh -e "connect --locator=localhost[10331]" -e "list gateways"
- ...
- (2) Executing - list gateways
-
- Gateways
-
- GatewaySender
+``` pre
+gfsh -e "connect --locator=localhost[10331]" -e "list gateways"
+...
+(2) Executing - list gateways
- GatewaySender Id | Member | Remote Cluster Id | Type | Status | Queued Events | Receiver Location
- ---------------- | --------------------------------- | ----------------- | -------- | ------- | ------------- | -----------------
- ln | boglesbymac(ny-1:88641)<v2>:33491 | 2 | Parallel | Running | 0 | boglesbymac:5037
- ln | boglesbymac(ny-2:88705)<v3>:29329 | 2 | Parallel | Running | 0 | boglesbymac:5064
- ln | boglesbymac(ny-3:88715)<v4>:36808 | 2 | Parallel | Running | 0 | boglesbymac:5132
- ln | boglesbymac(ny-4:88724)<v5>:52993 | 2 | Parallel | Running | 0 | boglesbymac:5324
+GatewaySender Section
- GatewayReceiver
+GatewaySender Id | Member | Remote Cluster Id | Type | Status | Queued Events | Receiver Location
+---------------- | --------------------------------- | ----------------- | -------- | ------- | ------------- | -----------------
+ln | mymac(ny-1:88641)<v2>:33491 | 2 | Parallel | Running | 0 | mymac:5037
+ln | mymac(ny-2:88705)<v3>:29329 | 2 | Parallel | Running | 0 | mymac:5064
+ln | mymac(ny-3:88715)<v4>:36808 | 2 | Parallel | Running | 0 | mymac:5132
+ln | mymac(ny-4:88724)<v5>:52993 | 2 | Parallel | Running | 0 | mymac:5324
- Member | Port | Sender Count | Sender's Connected
- --------------------------------- | ---- | ------------ | --------------------------------------------------------------------------
- boglesbymac(ny-1:88641)<v2>:33491 | 5057 | 24 | ["boglesbymac(ln-1:88651)<v2>:48277","boglesbymac(ln-4:88681)<v5>:42784","boglesbymac(ln-2:88662)<v3>:12796","boglesbymac(ln-3:88672)<v4>:43675"]
- boglesbymac(ny-2:88705)<v3>:29329 | 5082 | 0 | []
- boglesbymac(ny-3:88715)<v4>:36808 | 5371 | 0 | []
- boglesbymac(ny-4:88724)<v5>:52993 | 5247 | 0 | []
+GatewayReceiver Section
+ Member | Port | Sender Count | Senders Connected
+--------------------------------- | ---- | ------------ | --------------------------------------------------------------------------
+mymac(ny-1:88641)<v2>:33491 | 5057 | 24 | ["mymac(ln-1:88651)<v2>:48277","mymac(ln-4:88681)<v5>:42784","mymac(ln-2:88662)<v3>:12796","mymac(ln-3:88672)<v4>:43675"]
+mymac(ny-2:88705)<v3>:29329 | 5082 | 0 | []
+mymac(ny-3:88715)<v4>:36808 | 5371 | 0 | []
+mymac(ny-4:88724)<v5>:52993 | 5247 | 0 | []
+```
Execute the load-balance command:
+``` pre
Review comment:
One format correction: please insert a blank line following "Execute the load-balance command:" so Markdown will properly recognize the first line of the example code. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6372: GEODE-4709: Add list gateways output sample in UG
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6372:
URL: https://github.com/apache/geode/pull/6372#issuecomment-827865627
> @alb3rtobr fyi if you had created your PR with the "allow edits from maintainers" box checked, Dave or I could fix small things like this missing blank line and save some back-and-forth.
@onichols-pivotal thanks for the tip, I did not know that option exists :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org