[GitHub] [druid] imply-cheddar commented on pull request #13914: Add back function signature for compat

["imply-cheddar (via GitHub)" <gi...@apache.org>]

imply-cheddar commented on PR #13914:
URL: https://github.com/apache/druid/pull/13914#issuecomment-1463171904

   The previous run of the tests on this failed with 2 types of failures:
   
   Other tests failed due to coverage.  I think we can ignore that for now.
   
   The Static Checks failed with
   
   ```
   Error:  processing/src/main/java/org/apache/druid/data/input/MaxSizeSplitHintSpec.java:45 -- Field has one usage but it is not reachable from entry points.
   Error:  processing/src/main/java/org/apache/druid/data/input/SegmentsSplitHintSpec.java:43 -- Field has one usage but it is not reachable from entry points.
   ```
   
   Which is very much unrelated to my change.  I've added some supressions that hopefully make those disappear, but even if they don't, I think this is safe to merge.  Objections?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org