You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/11 09:12:59 UTC
[GitHub] [iotdb] Sunny-Island opened a new pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Sunny-Island opened a new pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813
Add Flink IoTDB documents to website and docs. The documents include English and Chinese version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#issuecomment-796596921
The right doc link: https://github.com/apache/iotdb/tree/master/flink-iotdb-connector
And don't forget the doc of flink-tsfile-connector. :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#discussion_r594078752
##########
File path: docs/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,32 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
Review comment:
Function -> Motivation
##########
File path: docs/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,32 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
+```
+The example is to show how to send data to a IoTDB server from a Flink job.
Review comment:
Do not use "```" to wrap the description.
##########
File path: docs/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,32 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
+```
+The example is to show how to send data to a IoTDB server from a Flink job.
Review comment:
To get the codes mentioned in this doc, please visit `example/flink` in source codes.
##########
File path: docs/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,32 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
+```
+The example is to show how to send data to a IoTDB server from a Flink job.
Review comment:
This example shows a case that:
1. a simulated Source `SensorSource` generates data points per 1 second;
2. Flink uses IoTDBSink to consume the generated data points and write the data into IoTDB.
##########
File path: docs/zh/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,41 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# Flink IoTDB 连接器
+
+## 功能
+```
+该示例演示了如何从一个 Flink job 中发送数据到 IoTDB server。
+```
+
+## 使用
+
+* 启动 IoTDB server
+* 运行 `org.apache.iotdb.flink.FlinkIoTDBSink.java` 将 Flink job 运行在本地的集群上。
+
+# TsFile的Flink连接器
+
+## 使用
+
+* 运行 `org.apache.iotdb.flink.FlinkTsFileBatchSource.java` 在本地集群上创建一个 Tsfile 并通过一个 Flink Dataset job 读取它。
Review comment:
这些和TsFile相关的似乎不需要在这文档里。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#issuecomment-805389724
:( There is an error...
see https://github.com/apache/iotdb/pull/2893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Sunny-Island commented on a change in pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
Sunny-Island commented on a change in pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#discussion_r594916119
##########
File path: docs/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,32 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
+```
+The example is to show how to send data to a IoTDB server from a Flink job.
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 merged pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#issuecomment-796591025
Good job. Welcome to the IoTDB community!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Sunny-Island commented on pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
Sunny-Island commented on pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#issuecomment-804548654
Look good to me !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#issuecomment-804119623
@Sunny-Island I modified a few codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Sunny-Island commented on a change in pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
Sunny-Island commented on a change in pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#discussion_r594917600
##########
File path: docs/UserGuide/Ecosystem Integration/Flink IoTDB.md
##########
@@ -0,0 +1,32 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
Review comment:
New doc is available. This change may not be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #2813: [IOTDB-1214] Add Flink-IoTDB documents
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #2813:
URL: https://github.com/apache/iotdb/pull/2813#discussion_r592188172
##########
File path: docs/UserGuide/Ecosystem Integration/Flink-IoTDB.md
##########
@@ -0,0 +1,41 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+# IoTDB-Flink-Connector Example
+
+## Function
+```
+The example is to show how to send data to a IoTDB server from a Flink job.
Review comment:
Please put the link of the example on the document :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org