[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4479: ARTEMIS-4191 Adding debug statements around reclaiming and compacting

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on code in PR #4479:
URL: https://github.com/apache/activemq-artemis/pull/4479#discussion_r1195388162


##########
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
##########
@@ -2625,12 +2631,13 @@ private void scheduleCompact() {
          return;
       }
 
+      logger.debug("JournalImpll::scheduleCompact");

Review Comment:
   Just checking its intended...this one is debug when all the others added are trace?



##########
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
##########
@@ -3565,6 +3580,8 @@ protected void moveNextFile(final boolean scheduleReclaim, boolean blockOnClose)
 
       if (scheduleReclaim) {
          scheduleReclaim();
+      } else {
+         logger.trace("JournalImpl::moveNextFile scheduleReclaim is false ( {} ), not calling scheduleReclaim", scheduleReclaim);

Review Comment:
   Seems odd to have a text statement it is false, and then also a placeholder printing the same value as well (also the arg for that will be autoboxing the boolean...not necessarily an issue if it isnt especially hot or typically does scheduleReclaim)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org