You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/28 12:17:57 UTC
[GitHub] [tvm] lhutton1 opened a new pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
lhutton1 opened a new pull request #10408:
URL: https://github.com/apache/tvm/pull/10408
In light of the flaky failures seen when running these sorts of tests (issues: #10300 and #10314), adding a second attempt if the first attempt fails to try to help reduce the number of failures observed in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on a change in pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #10408:
URL: https://github.com/apache/tvm/pull/10408#discussion_r816486407
##########
File path: tests/python/contrib/test_ethosu/infra.py
##########
@@ -251,13 +251,23 @@ def verify_source(
"""
interface_api = "c"
test_runner = create_test_runner(accel, enable_usmp)
- run_and_check(
- models,
- test_runner,
- interface_api,
- workspace_byte_alignment=16,
- data_linkage=AOTDataLinkage(section="ethosu_scratch", alignment=16),
- )
+
+ def run_mod():
+ run_and_check(
+ models,
+ test_runner,
+ interface_api,
+ workspace_byte_alignment=16,
+ data_linkage=AOTDataLinkage(section="ethosu_scratch", alignment=16),
+ )
+
+ # TODO(lhutton1) This is a quick and dirty work around to help temporarily reduce
+ # the flakyness of the tests. Will remove once #10300 is resolved.
+ try:
+ run_mod()
+ except AssertionError:
Review comment:
@lhutton1 thanks for quickly taking this up!
We need to print out the logs if it fails (even once) if we are ever to fix this. i.e. we let it rerun but we do print the logs.
Generally, printing out run_log and compile_log would give the sufficient info to debug this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a change in pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on a change in pull request #10408:
URL: https://github.com/apache/tvm/pull/10408#discussion_r816653220
##########
File path: tests/python/contrib/test_ethosu/infra.py
##########
@@ -251,13 +251,23 @@ def verify_source(
"""
interface_api = "c"
test_runner = create_test_runner(accel, enable_usmp)
- run_and_check(
- models,
- test_runner,
- interface_api,
- workspace_byte_alignment=16,
- data_linkage=AOTDataLinkage(section="ethosu_scratch", alignment=16),
- )
+
+ def run_mod():
+ run_and_check(
+ models,
+ test_runner,
+ interface_api,
+ workspace_byte_alignment=16,
+ data_linkage=AOTDataLinkage(section="ethosu_scratch", alignment=16),
+ )
+
+ # TODO(lhutton1) This is a quick and dirty work around to help temporarily reduce
+ # the flakyness of the tests. Will remove once #10300 is resolved.
+ try:
+ run_mod()
+ except AssertionError:
Review comment:
I think we should try to land #10214 first, then rebase this patch and print the RuntimeError before the retry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] grant-arm commented on pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
Posted by GitBox <gi...@apache.org>.
grant-arm commented on pull request #10408:
URL: https://github.com/apache/tvm/pull/10408#issuecomment-1058030882
Thanks for looking at this @lhutton1
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #10408:
URL: https://github.com/apache/tvm/pull/10408#issuecomment-1057985492
cc @grant-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10408:
URL: https://github.com/apache/tvm/pull/10408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on a change in pull request #10408: [AOT] Rerun FVP test incase of first attempt failure
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #10408:
URL: https://github.com/apache/tvm/pull/10408#discussion_r816487196
##########
File path: tests/python/contrib/test_ethosu/infra.py
##########
@@ -251,13 +251,23 @@ def verify_source(
"""
interface_api = "c"
test_runner = create_test_runner(accel, enable_usmp)
- run_and_check(
- models,
- test_runner,
- interface_api,
- workspace_byte_alignment=16,
- data_linkage=AOTDataLinkage(section="ethosu_scratch", alignment=16),
- )
+
+ def run_mod():
+ run_and_check(
+ models,
+ test_runner,
+ interface_api,
+ workspace_byte_alignment=16,
+ data_linkage=AOTDataLinkage(section="ethosu_scratch", alignment=16),
+ )
+
+ # TODO(lhutton1) This is a quick and dirty work around to help temporarily reduce
+ # the flakyness of the tests. Will remove once #10300 is resolved.
+ try:
+ run_mod()
+ except AssertionError:
Review comment:
Or will it already happen by the time we land the other logging PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org