You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/10/31 21:25:41 UTC

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20640


Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................

IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes

Prior deflae attempt at IMPALA-12499 does not seem sufficient. There are
still sporadic failures happening in
test_hdfs_scanner_thread_non_reserved_bytes. This patch further attempt
to deflake it by running it serially and skip it in dockerized
environment. This patch also fix small comment mistakes in
hdfs-scan-node.cc.

Testing:
- Loop and pass the test 100 times in local minicluster environment.

Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
---
M be/src/exec/hdfs-scan-node.cc
M tests/common/skip.py
M tests/query_test/test_mem_usage_scaling.py
3 files changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/20640/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14290/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Oct 2023 21:55:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20640

to look at the new patch set (#2).

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................

IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes

Prior deflake attempt at IMPALA-12499 does not seem sufficient. There
are still sporadic failures happening in
test_hdfs_scanner_thread_non_reserved_bytes. This patch further attempt
to deflake it by running it serially and skip it in dockerized
environment. This patch also fix small comment mistakes in
hdfs-scan-node.cc.

Testing:
- Loop and pass the test 100 times in local minicluster environment.

Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
---
M be/src/exec/hdfs-scan-node.cc
M tests/common/skip.py
M tests/query_test/test_mem_usage_scaling.py
3 files changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/20640/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20640

to look at the new patch set (#3).

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................

IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes

Prior deflake attempt at IMPALA-12499 does not seem sufficient. There
are still sporadic failures happening in
test_hdfs_scanner_thread_non_reserved_bytes. This patch further attempt
to deflake it by:
- Injecting 100ms sleep every time scanner thread obtain new scan range.
- Running it serially.
- Skip it in dockerized environment.

This patch also fix small comment mistakes in hdfs-scan-node.cc.

Testing:
- Loop and pass the test 100 times in local minicluster environment.

Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
---
M be/src/exec/hdfs-scan-node.cc
M testdata/workloads/functional-query/queries/QueryTest/hdfs-scanner-thread-non-reserved-bytes.test
M tests/common/skip.py
M tests/query_test/test_mem_usage_scaling.py
4 files changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/20640/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Nov 2023 07:41:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9869/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Nov 2023 07:42:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Nov 2023 07:42:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20640/3/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/20640/3/tests/common/skip.py@183
PS3, Line 183:       IS_DOCKERIZED_TEST_CLUSTER, reason="Dockerized env too slow for test.")
> Any theories why this is true?
In IMPALA-12499, I suspect that the root fragment is not fast enough to pull rows => the batch queue is full => no extra thread is launched. I did simplify the test query to be a count star query, but still see flakiness happen in both regular cluster and dockerized cluster.

Maybe it will finally become deterministic just by running it serial (no concurrent queries) + sleep inject, but I just don't want to come back patching this test again if it turns out still flaky in dockerized environment.



-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:04:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20640/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20640/2//COMMIT_MSG@12
PS2, Line 12: running it serially and skip it in dockerized
            : environment
Injecting sleep on scanner thread should further harden this test, like this one:
https://github.com/apache/impala/blob/09f15eea78e54464699cf7e42b4433d5b74e8231/be/src/exec/hdfs-scan-node.cc#L443-L444

Maybe somewhere after obtaining scan range.



-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 22:41:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20640/3/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/20640/3/tests/common/skip.py@183
PS3, Line 183:       IS_DOCKERIZED_TEST_CLUSTER, reason="Dockerized env too slow for test.")
Any theories why this is true?



-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 22:59:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20640/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20640/2//COMMIT_MSG@12
PS2, Line 12: 
            : - Injecting
> Injecting sleep on scanner thread should further harden this test, like thi
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 22:55:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14302/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:23:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................

IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes

Prior deflake attempt at IMPALA-12499 does not seem sufficient. There
are still sporadic failures happening in
test_hdfs_scanner_thread_non_reserved_bytes. This patch further attempt
to deflake it by:
- Injecting 100ms sleep every time scanner thread obtain new scan range.
- Running it serially.
- Skip it in dockerized environment.

This patch also fix small comment mistakes in hdfs-scan-node.cc.

Testing:
- Loop and pass the test 100 times in local minicluster environment.

Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Reviewed-on: http://gerrit.cloudera.org:8080/20640
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-scan-node.cc
M testdata/workloads/functional-query/queries/QueryTest/hdfs-scanner-thread-non-reserved-bytes.test
M tests/common/skip.py
M tests/query_test/test_mem_usage_scaling.py
4 files changed, 15 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Nov 2023 12:12:19 +0000
Gerrit-HasComments: No