[GitHub] [netbeans] lbownik commented on a diff in pull request #5721: Adding a way to directly specify JTreg when no is known

["lbownik (via GitHub)" <gi...@apache.org>]

lbownik commented on code in PR #5721:
URL: https://github.com/apache/netbeans/pull/5721#discussion_r1149052517


##########
java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/jtreg/ActionProviderImpl.java:
##########
@@ -300,12 +305,34 @@ public String[] getExtraMakeTargets() {
                     try {
                         stop.started();
                         Process jtregProcess = new ProcessBuilder(options).start();
-                        BACKGROUND.post(new CopyReaderWriter(new InputStreamReader(jtregProcess.getInputStream()), io.getOut()));
-                        BACKGROUND.post(new CopyReaderWriter(new InputStreamReader(jtregProcess.getErrorStream()), io.getErr()));
+                        StringWriter errorOutput = new StringWriter();

Review Comment:
   how about initializing the size of errorOutput to a constant that will be enough most of the time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists