You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by mi...@apache.org on 2017/06/05 15:02:51 UTC

[10/14] incubator-trafficcontrol git commit: create user from API - PR comments fixes

create user from API - PR comments fixes


Project: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/commit/954db05f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/tree/954db05f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/diff/954db05f

Branch: refs/heads/master
Commit: 954db05fb6b30e6daa8ac1ca2cd15d1ed8a06bd1
Parents: 09c1731
Author: nir-sopher <ni...@gmail.com>
Authored: Mon Apr 10 16:49:43 2017 +0300
Committer: Jeremy Mitchell <mi...@gmail.com>
Committed: Mon Jun 5 09:01:58 2017 -0600

----------------------------------------------------------------------
 traffic_ops/app/lib/API/User.pm | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/954db05f/traffic_ops/app/lib/API/User.pm
----------------------------------------------------------------------
diff --git a/traffic_ops/app/lib/API/User.pm b/traffic_ops/app/lib/API/User.pm
index 22d22f8..fea38ab 100644
--- a/traffic_ops/app/lib/API/User.pm
+++ b/traffic_ops/app/lib/API/User.pm
@@ -276,20 +276,20 @@ sub create {
 	my $tenant_id = exists($params->{tenantId}) ? $params->{tenantId} :  $self->current_user_tenant();
 
 	my $values = {
-		address_line1 			=> defined_or_default($params->{addressLine1}, ""),
-		address_line2 			=> defined_or_default($params->{addressLine2}, ""),
-		city 				=> defined_or_default($params->{city}, ""),
-		company 			=> defined_or_default($params->{company}, ""),
-		country 			=> defined_or_default($params->{country}, ""),
+		address_line1 			=> $params->{addressLine1},
+		address_line2 			=> $params->{addressLine2},
+		city 				=> $params->{city},
+		company 			=> $params->{company},
+		country 			=> $params->{country},
 		email 				=> $params->{email},
 		full_name 			=> $params->{fullName},
-		new_user            		=> defined_or_default($params->{newUser}, 0),		
-		phone_number 			=> defined_or_default($params->{phoneNumber}, ""),
-		postal_code 			=> defined_or_default($params->{postalCode}, ""),
-		public_ssh_key 			=> defined_or_default($params->{publicSshKey}, ""),
+		new_user            		=> 0,		
+		phone_number 			=> $params->{phoneNumber},
+		postal_code 			=> $params->{postalCode},
+		public_ssh_key 			=> $params->{publicSshKey},
 		registration_sent 		=> undef,
 		role 				=> $params->{role},
-		state_or_province 		=> defined_or_default($params->{stateOrProvince}, ""),
+		state_or_province 		=> $params->{stateOrProvince},
 		username 			=> $params->{username},
 		uid                  		=> 0,		
 		gid                  		=> 0,