You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/11/20 19:05:02 UTC

[GitHub] bruth commented on a change in pull request #3026: Add bookkeeper service and other fixes

bruth commented on a change in pull request #3026: Add bookkeeper service and other fixes
URL: https://github.com/apache/pulsar/pull/3026#discussion_r235131549
 
 

 ##########
 File path: deployment/kubernetes/google-kubernetes-engine/bookie.yaml
 ##########
 @@ -155,6 +156,29 @@ spec:
             storage: 10Gi
         storageClassName: bookie-hdd
 
+
+---
+##
+## Define the Bookie headless service
+## In practice, in this case, it is only useful to have a view of
+## all the bookie pods that are present
 
 Review comment:
   Sure. I copied the comment from the generic k8s service definition, but I pushed a commit to make it more obvious.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services