You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/08/20 13:39:13 UTC

[GitHub] incubator-brooklyn pull request: Adds test for ssh streams being c...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/858

    Adds test for ssh streams being captures in VanillaSoftwareProcess

    Also adds `TaskPredicates`.
    
    And adds `TaskBuilder.displayName()` (deprecating the old `TaskBuilder.name()`) so that it is consistent with `Task.getDisplayName()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn tests/ssh-streams

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #858
    
----
commit f4533edb6bc17de165813192c063d7b5c27f02d3
Author: Aled Sage <al...@gmail.com>
Date:   2015-08-20T11:27:43Z

    Add TaskBuilder.displayName; deprecate TaskBuilder.name

commit 3385e7b3edebc05a6eab5229d4208226790b520f
Author: Aled Sage <al...@gmail.com>
Date:   2015-08-20T11:33:20Z

    Adds TaskPredicates

commit ce8e69d026bd15718bcebde94c0d95666e90b823
Author: Aled Sage <al...@gmail.com>
Date:   2015-08-20T11:33:33Z

    Adds VanillaSoftwareProcessStreamsIntegrationTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adds test for ssh streams being c...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/858#issuecomment-133149573
  
    @ahgittin thanks.
    
    What prompted it is us adding similar support for `VanillaWindowsProcess`, which currently does not capture the streams. It made sense to write the test for the ssh-case while @bostko works on the windows side of things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adds test for ssh streams being c...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/858#issuecomment-132987751
  
    LGTM.  i like the change to `displayName`.
    
    is there a failure which prompted this?  or just adding good integration tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adds test for ssh streams being c...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/858#issuecomment-132991574
  
    noticed `TaskPredicatesTest` is missing the RAT header; i'll add it when i push


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adds test for ssh streams being c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/858


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---