You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/10 23:29:09 UTC

[GitHub] [solr] noblepaul commented on a diff in pull request #1267: SOLR-16608: Ability to compress the collection state

noblepaul commented on code in PR #1267:
URL: https://github.com/apache/solr/pull/1267#discussion_r1066441928


##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -199,9 +199,15 @@ private class ClusterStateUpdater implements Runnable, Closeable {
 
     private SolrMetricsContext clusterStateUpdaterMetricContext;
 
+    private final int minimumStateSizeForCompression;

Review Comment:
   `size` is better compared to bytes
   
   `minimumBytesForCompression` vs `minimumStateSizeForCompression`
   
   however, we could use `minStateSizeForCompression` instead of `minimumStateSizeForCompression`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org