[GitHub] [hbase] frostruan commented on a diff in pull request #5253: HBASE-27885 expose metaCacheHits in MetricsConnection

["frostruan (via GitHub)" <gi...@apache.org>]

frostruan commented on code in PR #5253:
URL: https://github.com/apache/hbase/pull/5253#discussion_r1206366604


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaCache.java:
##########
@@ -253,6 +253,9 @@ public void testPreserveMetaCacheOnException() throws Exception {
           table.increment(increment);
           table.delete(delete);
           table.mutateRow(mutations);
+          // The value of the metaCacheHits counter is incremented by 6 in each round of the loop,
+          // and the first request will not hit cache
+          assertEquals(6 * i + 5, metrics.getMetaCacheHits());

Review Comment:
   Great suggestion ! Thanks a lot !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org