You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/13 14:12:10 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1077: [CELEBORN-132] ShuffleClient should not implement Cloneable
pan3793 opened a new pull request, #1077:
URL: https://github.com/apache/incubator-celeborn/pull/1077
### What changes were proposed in this pull request?
Remove interface `Cloneable` declaration from `ShuffleClient`, and minor code improvement.
### Why are the changes needed?
ShuffleClient should not implement Cloneable, the original intention here is Closeable, but the close method throws IOException (which is a checked exception, so catch or throw is necessary), to make the code clean and simple, here just remove the implement Cloneable.
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1077: [CELEBORN-132] ShuffleClient should not implement Cloneable
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1077:
URL: https://github.com/apache/incubator-celeborn/pull/1077#issuecomment-1348677070
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1077?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1077](https://codecov.io/gh/apache/incubator-celeborn/pull/1077?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f54188) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/dcc242e65035eabea50137b28c4292d77d6bd310?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcc242e) will **increase** coverage by `0.01%`.
> The diff coverage is `42.85%`.
```diff
@@ Coverage Diff @@
## main #1077 +/- ##
============================================
+ Coverage 25.27% 25.29% +0.01%
- Complexity 774 776 +2
============================================
Files 212 212
Lines 18032 18032
Branches 2036 2036
============================================
+ Hits 4558 4561 +3
+ Misses 13167 13165 -2
+ Partials 307 306 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1077?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/celeborn/client/ShuffleClient.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1077/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvU2h1ZmZsZUNsaWVudC5qYXZh) | `4.65% <0.00%> (ø)` | |
| [.../org/apache/celeborn/client/ShuffleClientImpl.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1077/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvU2h1ZmZsZUNsaWVudEltcGwuamF2YQ==) | `19.95% <60.00%> (ø)` | |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1077/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `77.92% <0.00%> (+1.35%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1077: [CELEBORN-132] ShuffleClient should not implement Cloneable
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1077:
URL: https://github.com/apache/incubator-celeborn/pull/1077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org