You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/11 12:33:47 UTC
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #210: Allow basedir system property to be null for build info.txt
slawekjaranowski opened a new pull request, #210:
URL: https://github.com/apache/maven-integration-testing/pull/210
- basedir can be null when test is executed by IDE, use default value
- use try-with-resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #210: Allow basedir system property to be null for build info.txt
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #210:
URL: https://github.com/apache/maven-integration-testing/pull/210#discussion_r1020893198
##########
core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java:
##########
@@ -42,46 +44,34 @@ public class TestSuiteOrdering implements ClassOrderer
final Map<Class<?>, Integer> tests = new HashMap<>();
- private static void infoProperty( PrintStream info, String property )
+ private static void infoProperty( Writer info, String property ) throws IOException
{
- info.println( property + ": " + System.getProperty( property ) );
+ info.append( property ).append( ": " ).append( System.getProperty( property ) );
Review Comment:
revert to PrintStrem ... not need improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #210: Allow basedir system property to be null for build info.txt
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #210:
URL: https://github.com/apache/maven-integration-testing/pull/210#discussion_r1020883194
##########
core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java:
##########
@@ -42,46 +44,34 @@ public class TestSuiteOrdering implements ClassOrderer
final Map<Class<?>, Integer> tests = new HashMap<>();
- private static void infoProperty( PrintStream info, String property )
+ private static void infoProperty( Writer info, String property ) throws IOException
{
- info.println( property + ": " + System.getProperty( property ) );
+ info.append( property ).append( ": " ).append( System.getProperty( property ) );
Review Comment:
Wthere is the line separator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #210: Allow basedir system property to be null for build info.txt
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #210:
URL: https://github.com/apache/maven-integration-testing/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org