[GitHub] sijie commented on a change in pull request #1701: autorecovery-use-metadata-driver (part 4) : provide an `AuditorSelector` interface to abstract leader election logic for AuditorElector

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1701: autorecovery-use-metadata-driver (part 4) : provide an `AuditorSelector` interface to abstract leader election logic for AuditorElector
URL: https://github.com/apache/bookkeeper/pull/1701#discussion_r222002573
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java
 ##########
 @@ -250,16 +252,26 @@ public synchronized LedgerManagerFactory getLedgerManagerFactory()
         return lmFactory;
     }
 
-    @Override
-    public void close() {
-        if (null != lmFactory) {
+    public AuditorSelector getAuditorSelector(String bookieId) {
+        return new ZkAuditorSelector(bookieId, zk, new ServerConfiguration(conf));
+    }
+
+    protected synchronized void closeLedgerManagerFactory() {
 
 Review comment:
   you already synchronized at line 261, do we still need this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services