You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/13 19:21:26 UTC
[GitHub] [iceberg] RussellSpitzer opened a new pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
RussellSpitzer opened a new pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819
Since we changed our implementation of Spark3BinPackStrategy we no longer need some
of the functionality that was previously in FileRewriteCoordinator. Here we remove
those functions and related test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819#issuecomment-880895715
I think it actually still does coordination at least in my mind :) So I don't mind. I figure we really just removed the "commit" portion of it's job, but it's still in charge of coordinating rewrites and their results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819#issuecomment-879339518
@rdblue + @aokolnychyi Like we discussed previously
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819#issuecomment-880896053
Let's keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819#issuecomment-880894329
Thanks, @RussellSpitzer!
Do we want to consider renaming this class as it is no longer a coordinator? Something like `FileRewriteOutputManager` or similar? Given the number of places we will need to change, it seems like an overkill. Thoughts, @RussellSpitzer @rdblue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2819: Spark: Remove Unused FileRewriteCoordinator Functions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2819:
URL: https://github.com/apache/iceberg/pull/2819#issuecomment-880887139
Let me see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org