You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/09 19:04:05 UTC
[GitHub] [incubator-pinot] quietgopher opened a new pull request #5131: Fix
an NPE that is encountered when the offline table config does not specify a
time column but the realtime table config does.
quietgopher opened a new pull request #5131: Fix an NPE that is encountered when the offline table config does not specify a time column but the realtime table config does.
URL: https://github.com/apache/incubator-pinot/pull/5131
https://github.com/apache/incubator-pinot/issues/5130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5131: Fix an NPE
that is encountered when the offline table config does not specify a time
column but the realtime table config does.
Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5131: Fix an NPE that is encountered when the offline table config does not specify a time column but the realtime table config does.
URL: https://github.com/apache/incubator-pinot/pull/5131#issuecomment-596756068
@quietgopher Thanks for working on this. Your fix will still throw an exception if the time column doesn't exist in offline table. You'll probably need to add the time column to offline table config before adding the realtime table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] quietgopher commented on issue #5131: Fix an NPE
that is encountered when the offline table config does not specify a time
column but the realtime table config does.
Posted by GitBox <gi...@apache.org>.
quietgopher commented on issue #5131: Fix an NPE that is encountered when the offline table config does not specify a time column but the realtime table config does.
URL: https://github.com/apache/incubator-pinot/pull/5131#issuecomment-596758849
Yea, I fixed my own configs too.
The tests are failing for me locally with unrelated errors ("The forked VM terminated without properly saying goodbye. VM crash or System.exit called?"). Let's wait for the travis to finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli merged pull request #5131: Fix an NPE
that is encountered when the offline table config does not specify a time
column but the realtime table config does.
Posted by GitBox <gi...@apache.org>.
jackjlli merged pull request #5131: Fix an NPE that is encountered when the offline table config does not specify a time column but the realtime table config does.
URL: https://github.com/apache/incubator-pinot/pull/5131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org