You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/06/07 21:29:59 UTC
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21494
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
IMPALA-13146: Download NodeJS from native toolchain
Some test runs have had issues downloading the NodeJS
tarball from the nodejs servers. This changes the
test to download from our native toolchain to make this
more reliable. This means that future upgrades to
NodeJS will need to upload new tarballs to the native
toolchain.
Testing:
- Ran x86_64/ARM javascript tests
Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
---
M tests/run-js-tests.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21494/1
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21494 )
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Jun 2024 03:02:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21494 )
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10699/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2024 21:56:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21494 )
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Jun 2024 16:21:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21494 )
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
IMPALA-13146: Download NodeJS from native toolchain
Some test runs have had issues downloading the NodeJS
tarball from the nodejs servers. This changes the
test to download from our native toolchain to make this
more reliable. This means that future upgrades to
NodeJS will need to upload new tarballs to the native
toolchain.
Testing:
- Ran x86_64/ARM javascript tests
Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Reviewed-on: http://gerrit.cloudera.org:8080/21494
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Surya Hebbar <sh...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
---
M tests/run-js-tests.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Surya Hebbar: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21494 )
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Jun 2024 09:40:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13146: Download NodeJS from native toolchain
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21494 )
Change subject: IMPALA-13146: Download NodeJS from native toolchain
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16303/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2024 21:55:14 +0000
Gerrit-HasComments: No