[GitHub] [spark] planga82 commented on a change in pull request #27375: [WIP][SPARK-30664][Web UI] Add optional metrics to all-stages page

[GitBox <gi...@apache.org>]

planga82 commented on a change in pull request #27375: [WIP][SPARK-30664][Web UI] Add optional metrics to all-stages page
URL: https://github.com/apache/spark/pull/27375#discussion_r379827048
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
 ##########
 @@ -284,18 +310,52 @@ private[ui] class StagePagedTable(
           {UIUtils.makeProgressBar(started = stageData.numActiveTasks,
           completed = stageData.numCompleteTasks, failed = stageData.numFailedTasks,
           skipped = 0, reasonToNumKilled = stageData.killedTasksSummary, total = info.numTasks)}
-        </td>
-        <td>{data.inputReadWithUnit}</td>
-        <td>{data.outputWriteWithUnit}</td>
-        <td>{data.shuffleReadWithUnit}</td>
-        <td>{data.shuffleWriteWithUnit}</td> ++
-        {
-          if (isFailedStage) {
-            failureReasonHtml(info)
-          } else {
-            Seq.empty
-          }
-        }
+        </td> ++
+        {if (metrics.contains("Input")) {
+          <td>{data.inputReadWithUnit}</td>
+        } else {
+          Seq.empty
+        }} ++
+        {if (metrics.contains("Output")) {
 
 Review comment:
   Could we find a way to avoid all this duplicate code? Something like iterate over optionalHeaders.keys or something like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org