You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/28 13:51:43 UTC

[GitHub] [zookeeper] maoling opened a new pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

maoling opened a new pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742


   - when running the `QuorumOracleMajTest` and sub tests of `QuorumBase`(e.g: `MultiOpSessionUpgradeTest`), we generate lots of useless files which are not exempt from `Git`. we should delete them after the finish of one UT.
   ```
   ✗ tree zookeeper-server/tmp/
   zookeeper-server/tmp/
   └── oraclePath
       ├── 0
       │   └── mastership
       │       └── value
       └── 1
           └── mastership
               └── value
   ```
   - fix a typo in the `zookeeperOracleQuorums.md `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] chingchan1996 commented on pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

Posted by GitBox <gi...@apache.org>.
chingchan1996 commented on pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742#issuecomment-938522341


   I went through the changes. From my point of view, it’s good and fail to criticize. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling commented on pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742#issuecomment-938517142


   - @chingchan1996 Any concerns ? 
   - @eolivelli @ztzg  we are suffering from this issue. PTAL
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling commented on pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742#issuecomment-917628510


   @chingchan1996  PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] chingchan1996 commented on pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

Posted by GitBox <gi...@apache.org>.
chingchan1996 commented on pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742#issuecomment-918066966


   ACK. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling closed pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] asfgit closed pull request #1742: ZOOKEEPER-4349: delete the useless oraclePath directory generated by test suit

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1742:
URL: https://github.com/apache/zookeeper/pull/1742


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org