You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:59:28 UTC
[GitHub] [airflow] potiuk opened a new pull request #16948: Pulls latest images to build images in "Build Image" flow
potiuk opened a new pull request #16948:
URL: https://github.com/apache/airflow/pull/16948
The recent switching to GHCR.io revealed a problem with misconfigured
GITHUB_REGISTRY_PULL_IMAGE_TAG variable for PROD images.
It was trying to pull build image with COMMIT_SHA before it was
built (This was previously hidden by fallback of pulling image
from DockerHub and one of the reasons of slower builds of PROD images
This PR should fix it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16948: Pulls latest images to build images in "Build Image" flow
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16948:
URL: https://github.com/apache/airflow/pull/16948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16948: Pulls latest images to build images in "Build Image" flow
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16948:
URL: https://github.com/apache/airflow/pull/16948#issuecomment-878446442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org