You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/06 11:23:08 UTC

[GitHub] [flink] tillrohrmann commented on issue #10608: [FLINK-15300][Runtime] Fix sanity check to not fail if shuffle memory fraction is out of min/max range

tillrohrmann commented on issue #10608: [FLINK-15300][Runtime] Fix sanity check to not fail if shuffle memory fraction is out of min/max range
URL: https://github.com/apache/flink/pull/10608#issuecomment-571104024
 
 
   Ok I understand this point and I'm not adamant on changing it. It seems however a bit inconsistent, because there are memory budgets (jvm overhead and shuffle) where `0` also does not make sense from your stand point. Maybe we could add a comment stating this contract. This might help for future maintenance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services