You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/29 16:01:43 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8288: ARROW-6043: [Python] Array equals returns incorrectly if NaNs are in arrays

pitrou commented on a change in pull request #8288:
URL: https://github.com/apache/arrow/pull/8288#discussion_r496849997



##########
File path: python/pyarrow/array.pxi
##########
@@ -1009,7 +1009,8 @@ cdef class Array(_PandasConvertible):
             return NotImplemented
 
     def equals(Array self, Array other):

Review comment:
       Why not:
   ```python
       def equals(Array self, Array other, *, nans_equal=True):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org