You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "timoninmaxim (via GitHub)" <gi...@apache.org> on 2025/08/01 06:56:14 UTC

Re: [PR] IGNITE-25914 Refactor NearCacheUpdates message [ignite]

timoninmaxim commented on code in PR #12200:
URL: https://github.com/apache/ignite/pull/12200#discussion_r2247141567


##########
modules/codegen2/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -514,6 +537,21 @@ private String messageCollectionItemType(TypeMirror type) throws Exception {
         return "MSG";
     }
 
+    /**
+     * @param type Type.
+     * @return true if the given type is a boxed primitive.
+     */
+    private boolean boxedType(TypeMirror type) {
+        try {
+            env.getTypeUtils().unboxedType(type);

Review Comment:
   code duplication - `unboxedType` invokes twice. It looks pretty heavy operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org