You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by hequn8128 <gi...@git.apache.org> on 2018/07/01 13:20:30 UTC

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

Github user hequn8128 commented on the issue:

    https://github.com/apache/flink/pull/6233
  
    Hi @snuyanzin , thanks for your PR. The code looks good and the `deepToString()` function returns result correctly. I could not spot any issues with the implementation. To make the PR better, I think we can add a test in `CliUtilsTest` to test the `rowToString` function, since code in the function also has been changed. BTW, the PR template can be done better. See for PR https://github.com/apache/flink/pull/5811 as an example.
    Best, Hequn


---