You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2012/09/07 18:26:26 UTC

svn commit: r1382085 - in /incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events: SparkDNDList_events.mxml baselines/ListAbcDND1_dragComplete.png baselines/ListAbcDND1_dragDrop.png

Author: aharui
Date: Fri Sep  7 16:26:26 2012
New Revision: 1382085

URL: http://svn.apache.org/viewvc?rev=1382085&view=rev
Log:
Another attempt at stabilizing dragdrop tests.  These tests invoke the dragscroll code which relies on timer events which means that some runs get one more timer event than others and the list scrolls a bit more.  This new pattern waits for a certain number of dragOver events which are dispatched as the dragScroll code handles the timer events.

Modified:
    incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/SparkDNDList_events.mxml
    incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/baselines/ListAbcDND1_dragComplete.png
    incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/baselines/ListAbcDND1_dragDrop.png

Modified: incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/SparkDNDList_events.mxml
URL: http://svn.apache.org/viewvc/incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/SparkDNDList_events.mxml?rev=1382085&r1=1382084&r2=1382085&view=diff
==============================================================================
--- incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/SparkDNDList_events.mxml (original)
+++ incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/SparkDNDList_events.mxml Fri Sep  7 16:26:26 2012
@@ -433,9 +433,11 @@
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="195" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="197" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="196" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
-		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="197" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
+		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="197" />
+		<WaitForEvent target="l2" eventName="dragOver" numExpectedEvents="2" />
 		<DispatchMouseEvent target="l2" type="mouseUp" localX="50" localY="197"  waitTarget="l1" waitEvent="dragComplete" />
-		<Pause timeout="300" />
+		<WaitForEffectsToEnd/>
+		<WaitForLayoutManager/>
 		<CompareBitmap numColorVariances="20" ignoreMaxColorVariance="true" target="hg" url="../events/baselines/$testID.png" />
             </body>
         </TestCase>
@@ -470,9 +472,11 @@
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="199" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="198" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="199" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
-		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="198" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
+		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="50" localY="198"/>
+		<WaitForEvent target="l2" eventName="dragOver" numExpectedEvents="2" />
 		<DispatchMouseEvent target="l2" type="mouseUp" localX="50" localY="199"  waitTarget="l2" waitEvent="dragDrop" timeout="50"/>
-		<Pause timeout="400" /><!-- drag scrolling seems to be continuing -->
+		<WaitForEffectsToEnd/>
+		<WaitForLayoutManager/>
 		<CompareBitmap numColorVariances="20" ignoreMaxColorVariance="true" target="hg" url="../events/baselines/$testID.png" />
             </body>
         </TestCase>
@@ -744,9 +748,11 @@
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="15" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="7" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="6" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
-		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="7" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
+		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="7"/>
+		<WaitForEvent target="l2" eventName="dragOver" numExpectedEvents="2" />
 		<DispatchMouseEvent target="l2" type="mouseUp" localX="145" localY="197"  waitTarget="l1" waitEvent="dragComplete" />
-		<Pause timeout="400" /><!-- drag scrolling seems to be continuing -->
+		<WaitForEffectsToEnd/>
+		<WaitForLayoutManager/>
 		<CompareBitmap numColorVariances="20" ignoreMaxColorVariance="true" target="hg" url="../events/baselines/$testID.png" />
             </body>
         </TestCase>
@@ -784,9 +790,11 @@
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="9" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="8" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
 		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="9" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
-		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="8" waitTarget="mx.managers::DragManager.mx_internal:dragProxy" waitEvent="move"/>
+		<DispatchMouseEvent target="l2" type="mouseMove" buttonDown="true" localX="145" localY="8"/>
+		<WaitForEvent target="l2" eventName="dragOver" numExpectedEvents="2" />
 		<DispatchMouseEvent target="l2" type="mouseUp" localX="145" localY="199"  waitTarget="l2" waitEvent="dragDrop" />
-		<Pause timeout="400" /><!-- drag scrolling seems to be continuing -->
+		<WaitForEffectsToEnd/>
+		<WaitForLayoutManager/>
 		<CompareBitmap numColorVariances="20" ignoreMaxColorVariance="true" target="hg" url="../events/baselines/$testID.png" />
             </body>
         </TestCase>

Modified: incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/baselines/ListAbcDND1_dragComplete.png
URL: http://svn.apache.org/viewvc/incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/baselines/ListAbcDND1_dragComplete.png?rev=1382085&r1=1382084&r2=1382085&view=diff
==============================================================================
Binary files - no diff available.

Modified: incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/baselines/ListAbcDND1_dragDrop.png
URL: http://svn.apache.org/viewvc/incubator/flex/sdk/branches/develop/mustella/tests/gumbo/components/ListDragDrop/events/baselines/ListAbcDND1_dragDrop.png?rev=1382085&r1=1382084&r2=1382085&view=diff
==============================================================================
Binary files - no diff available.