You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dragos <gi...@git.apache.org> on 2015/12/15 22:22:49 UTC
[GitHub] spark pull request: [WIP][SPARK-12345][Mesos] Don’t get the cano...
GitHub user dragos opened a pull request:
https://github.com/apache/spark/pull/10315
[WIP][SPARK-12345][Mesos] Don’t get the canonical path when building the command to execute on …
…Mesos executors. Otherwise, the resolved path will be dependent on the driver machine (following symlinks, making the path absolute).
- I don't know if this is the only thing needed to fix cluster-mode on Mesos (building Spark now)
- `getCanonicalPath` doesn't make sense there, but still it doesn't explain the *regression*. This code was there in 1.5.2, but the bug appears only in 1.6.0, so there's still explaining to do.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragos/spark issue/cluster-mode-12345
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10315
----
commit 444938e91ad2a498fc773d21aea501e70df86f25
Author: Iulian Dragos <ja...@gmail.com>
Date: 2015-12-15T21:17:38Z
Don’t get the canonical path when building the command to execute on Mesos executors. Otherwise, the resolved path will be dependent on the driver machine (following symlinks, making the path absolute).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12345][Mesos] Don’t get the cano...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10315#issuecomment-164906277
**[Test build #47753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47753/consoleFull)** for PR 10315 at commit [`444938e`](https://github.com/apache/spark/commit/444938e91ad2a498fc773d21aea501e70df86f25).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12345][Mesos] Don’t get the cano...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10315#issuecomment-164935279
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12345][Mesos] Don’t get the cano...
Posted by dragos <gi...@git.apache.org>.
Github user dragos closed the pull request at:
https://github.com/apache/spark/pull/10315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12345][Mesos] Don’t get the cano...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10315#issuecomment-164935281
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47753/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12345][Mesos] Don’t get the cano...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10315#issuecomment-164935128
**[Test build #47753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47753/consoleFull)** for PR 10315 at commit [`444938e`](https://github.com/apache/spark/commit/444938e91ad2a498fc773d21aea501e70df86f25).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org