[GitHub] [spark] AngersZhuuuu commented on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and  add v11 thrift protocol
URL: https://github.com/apache/spark/pull/26221#issuecomment-545427371
 
 
   > Could you add a README.txt like the one in Hive:
   > 
   > ```
   > Thrift commands to generate files from TCLIService.thrift:
   > --------------------
   > thrift --gen java:beans,hashcode -o src/gen/thrift if/TCLIService.thrift
   > ```
   > 
   > and keep the directory structure as created by it (i.e. code in `src/gen/thrift/gen-javabean`)
   > 
   > Now after running thrift, there needs to be a manual step of moving the code again to `src/gen`, because it always generates the `gen-javabean` directory.
   
   @juliuszsompolski  Done this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org