You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/21 18:55:20 UTC

[GitHub] [arrow] nealrichardson commented on pull request #7807: ARROW-6537 [R]: Pass column_types to CSV reader

nealrichardson commented on pull request #7807:
URL: https://github.com/apache/arrow/pull/7807#issuecomment-662045381


   > I'm still uncertain about the compact readr specification, because this needs col_names as well, i.e. we can't make the compact spec relevant to guessed or autogenerated names.
   
   I see the logic where the column names are inferred/generated in cpp/src/arrow/csv/reader.cc, it's just not exposed publicly. I could see adding a `column_names` attribute to `arrow::csv::TableReader`, so we could instantiate a reader, get column names, then make a new reader with the appropriate `*Options` objects. I can make a JIRA but I don't think we need to block this PR on that. 
   
   I get that the compact readr specification isn't all that useful as is since you also have to provide the col_names, but if we are planning to expose column names on TableReader, would it make sense to keep it in this PR for now? Or would you rather delete/stash it completely until we can support it without requiring col_names?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org