[GitHub] [tvm] wrongtest commented on a change in pull request #9678: Fix for tvm.build()'s name warning

[GitBox <gi...@apache.org>]

wrongtest commented on a change in pull request #9678:
URL: https://github.com/apache/tvm/pull/9678#discussion_r765385770



##########
File path: python/tvm/driver/build_module.py
##########
@@ -93,7 +93,7 @@ def schedule_to_module(
 def lower(
     inp: Union[schedule.Schedule, PrimFunc, IRModule],
     args: Optional[List[Union[Buffer, tensor.Tensor, Var]]] = None,
-    name: str = "main",
+    name: str = None,

Review comment:
       Yeal, you are right. I finally fail to resolve all name errors related to unittests with a minor change. Is it acceptable if the PR only remove the name warning of #9602?
   
    If the default name is changed, currently broken testcases I have seen are:
   - Test in microtvm require the function name `not` be `main` because of c code compilation.
   - While a various set of tests use "main" as the expected IR function name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org