You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/17 18:47:47 UTC
[GitHub] [ozone] kerneltime commented on a change in pull request #3104: HDDS-6213. Pluggable OzoneManager request handling hooks
kerneltime commented on a change in pull request #3104:
URL: https://github.com/apache/ozone/pull/3104#discussion_r809362752
##########
File path: dev-support/annotations/pom.xml
##########
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>ozone-annotation-processing</artifactId>
+ <version>1.3.0-SNAPSHOT</version>
+ <description>Apache Ozone annotation processing tools for validating custom
+ annotations at compile time.
+ </description>
+ <name>Apache Ozone Annotation Processing</name>
+ <packaging>jar</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <spotbugs.version>3.1.12</spotbugs.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs</artifactId>
+ <version>${spotbugs.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <!--
+ | It is required to add spotbugs dependency here, so that CI can check
+ | this package properly and does not fail the findbugs check.
+ -->
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs.version}</version>
+ <configuration>
+ <maxHeap>1024</maxHeap>
+ <xmlOutput>true</xmlOutput>
+ <includeTests>true</includeTests>
+ </configuration>
+ </plugin>
+ <!--
+ | Compiler plugin configuration have to be modified to compile the
+ | annotation processor, without having any annotation processor applied
+ | as due to the presence of
+ | META-INF/services/javac.annotation.processing.Processor the compilation
+ | would fail as the linked processor class can not be find while we are
+ | compiling it.
+ -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.9.0</version>
+ <configuration>
+ <source>1.8</source>
+ <target>1.8</target>
+ </configuration>
+ <executions>
+ <execution>
+ <id>default-compile</id>
+ <configuration>
+ <compilerArgument>-proc:none</compilerArgument>
Review comment:
Please add a note as to why we need `-proc:none` and the sequence of events that should occur when we fresh build the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org