You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/30 10:43:05 UTC

[GitHub] [pulsar] lhotari opened a new pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

lhotari opened a new pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050


   ### Motivation
   
   The current system topic concept doesn't seem to be consistent. It would be expected that topics in the "pulsar/system" namespace are considered as system topics.
   
   ### Modifications
   
   Change SystemTopicClient.isSystemTopic to consider all topics in pulsar/system namespace to be system topics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982538014


   @lhotari what it is a "System topic" ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982550699


   Thank you @lhotari for your pointer.
   
   I see that PIP-39 is still in "draft" status.
   @sijie  or @codelipenghui  do you mind marking as Accepted and cleaning up the Wiki for PIP-39 ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982547709


   > what it is a "System topic" ?
   
   @eolivelli The concept was introduced by #4955 / [PIP-39](https://github.com/apache/pulsar/wiki/PIP-39%3A-Namespace-Change-Events).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982549501


   @lhotari:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982512457






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #13050:
URL: https://github.com/apache/pulsar/pull/13050#issuecomment-983023068


   @codelipenghui Would you mind taking a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org