You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jan Høydahl (Jira)" <ji...@apache.org> on 2023/01/02 15:19:00 UTC
[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653632#comment-17653632 ]
Jan Høydahl commented on SOLR-10466:
------------------------------------
I feel quilty for adding this way back, but it was mostly a convenience method for users with only one collection.
If we keep it, I think it could move to builder and thus you'd need to build a new client if you want to have another default collection.
Other options would be a more dramatic refactor of the responsibility split between SolrClient and SolrRequest to lower the footprint of the client itself.
> setDefaultCollection should be deprecated in favor of SolrClientBuilder methods
> -------------------------------------------------------------------------------
>
> Key: SOLR-10466
> URL: https://issues.apache.org/jira/browse/SOLR-10466
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: 7.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setDefaultCollection}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org