[jira] [Comment Edited] (MESOS-5813) Port stout-tests suites to Windows

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482924#comment-16482924 ] 

Andrew Schwartzmeyer edited comment on MESOS-5813 at 8/27/18 10:30 PM:
-----------------------------------------------------------------------

We're now at 300 tests enabled vs 324 on Linux, or 92.6%.

More importantly, there are no more stout unit tests disabled with {{TEMP_DISABLED_ON_WINDOWS}}, meaning the remaining difference are mostly incompatible code.

Missing tests that won'd be ported:
 * FlagsFileTest.JSONFile: This tests deprecated code that pre-dates Windows support for Mesos.
 * OsSignalsTest.Suppress: Tests unused and deleted-on-Windows code.
 * OsTest.KilltreeNoRoot: "No root" is not supported
 * OsTest.SYMLINK_Chown: chown not supported
 * OsTest.Libraries: {LD_LIBRARY_PATH}} has no equivalent
 * OsTest.Mknod: "mknod" not supported
 * FsTest.Xattr: "xattr" not supported
 * ProcTest.Pids: All of {{/proc}} is a Linux thing
 * ProcTest.Cpus
 * ProcTest.SystemStatus
 * ProcTest.ProcessStatus
 * ProcTest.SingleThread
 * ProcTest.MultipleThreads
 * RmdirTest.RemoveDirectoryWithDeviceFile: Not supported
 * StrerrorTest.ValidHerrno: Explicitly tests POSIX function
 * SystemsTest.Uname: Tests unused and deleted-on-Windows code.
 * SystemsTest.Sysname: Tests unused and deleted-on-Windows code.
 * SystemsTest.Release: Tests unused and deleted-on-Windows code.

Missing tests that need to be investigated:
 * OsTest.Environment
 * OsTest.Children
 * OsTest.Killtree
 * OsTest.ProcessExists
 * OsTest.User
 * EnvTest.EraseEnv
 * RmdirContinueOnErrorTest.RemoveWithContinueOnError
 * OsSendfileTest.Sendfile

Missing tests that need 3rdparty support:
 * SVNTest.DiffPatch
 * SVNTtest.EmptyDiffPatch


was (Author: andschwa):
We're now at 300 tests enabled vs 324 on Linux, or 92.6%.

More importantly, there are no more stout unit tests disabled with {{TEMP_DISABLED_ON_WINDOWS}}, meaning the remaining difference are mostly incompatible code.

Missing tests that won'd be ported:
 * FlagsFileTest.JSONFile: This tests deprecated code that pre-dates Windows support for Mesos.
 * OsSignalsTest.Suppress: Tests unused and deleted-on-Windows code.
 * SystemsTest.Uname: Tests unused and deleted-on-Windows code.
 * SystemsTest.Sysname: Tests unused and deleted-on-Windows code.
 * SystemsTest.Release: Tests unused and deleted-on-Windows code.

Missing tests that need to be investigated:
 * OsTest.Environment
 * OsTest.Children
 * OsTest.Killtree
 * OsTest.KilltreeNoRoot
 * OsTest.ProcessExists
 * OsTest.User
 * OsTest.SYMLINK_Chown
 * OsTest.Libraries
 * OsTest.Mknod
 * ProcTest.Pids
 * ProcTest.Cpus
 * ProcTest.SystemStatus
 * ProcTest.ProcessStatus
 * ProcTest.SingleThread
 * ProcTest.MultipleThreads
 * EnvTest.EraseEnv
 * FsTest.Xattr
 * RmdirTest.RemoveDirectoryWithDeviceFile
 * RmdirContinueOnErrorTest.RemoveWithContinueOnError
 * StrerrorTest.ValidHerrno
 * OsSendfileTest.Sendfile

Missing tests that need 3rdparty support:
 * SVNTest.DiffPatch
 * SVNTtest.EmptyDiffPatch

> Port stout-tests suites to Windows
> ----------------------------------
>
>                 Key: MESOS-5813
>                 URL: https://issues.apache.org/jira/browse/MESOS-5813
>             Project: Mesos
>          Issue Type: Epic
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Major
>              Labels: microsoft, stout, windows
>
> This does not require enabling every test, as inevitably there will be disabled tests. However, all test files should be ported to Windows, and for each disabled test, an associated issue should exist. The exception is if the test does not make sense whatsoever for Windows, in which case it should be compiled out instead of temporarily disabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)