[jira] [Commented] (YARN-2674) Distributed shell AM may re-launch containers if RM work preserving restart happens

["Jian He (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230275#comment-14230275 ] 

Jian He commented on YARN-2674:
-------------------------------

[~chenchun], thanks for your patch. The patch should work fine.
Maybe a more standard way is to use the {{AMRMClient#getMatchingRequests}} to find out the matching resourceRequest and then call the removeContainerRequest method ?

> Distributed shell AM may re-launch containers if RM work preserving restart happens
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-2674
>                 URL: https://issues.apache.org/jira/browse/YARN-2674
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Chun Chen
>         Attachments: YARN-2674.1.patch
>
>
> Currently, if RM work preserving restart happens while distributed shell is running, distribute shell AM may re-launch all the containers, including new/running/complete. We must make sure it won't re-launch the running/complete containers.
> We need to remove allocated containers from AMRMClientImpl#remoteRequestsTable once AM receive them from RM. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)