You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Amruta Borkar <ar...@us.ibm.com> on 2017/05/23 23:06:34 UTC

Review Request 59497: Customize services shows inconsistent config-groups after clicking on Back

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59497/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Sangeeta Ravindran.


Bugs: AMBARI-21094
    https://issues.apache.org/jira/browse/AMBARI-21094


Repository: ambari


Description
-------

Steps to reproduce:
1. Go to Customize Services screen
2. Create a Custom HostGroup
3. Click Back button
4. Click Next Button
5. See that Custom Hostgroup still exists, but all the data including assigned hosts is erased.
Ambari typically erases all the changes when clicked on Back button, because the Custom HostGroup is not deleted but data related to it is deleted by Ambari, cluster state goes in inconsistent state.


Diffs
-----

  ambari-web/app/controllers/wizard/step7_controller.js 6685c0189a 


Diff: https://reviews.apache.org/r/59497/diff/1/


Testing
-------

Tested manually,
Attached output screenshots


File Attachments
----------------

HostGroupList_BeforeClickingBack
  https://reviews.apache.org/media/uploaded/files/2017/05/23/20029794-04d8-4611-83fe-884e30282ff7__HostGroupList_BeforeClickingBack.png
BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack
  https://reviews.apache.org/media/uploaded/files/2017/05/23/3853d6c3-5fd0-4604-9923-602df062b51f__BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack.png
BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack
  https://reviews.apache.org/media/uploaded/files/2017/05/23/2b28debe-b81f-4b25-946b-acdfc69a3042__BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack.png
BeforeCodeChange_HostGroupList_AfterlickingBack
  https://reviews.apache.org/media/uploaded/files/2017/05/23/5c9805e0-41ae-42fa-a87d-393f0da8a144__BeforeCodeChange_HostGroupList_AfterlickingBack.png
AfterCodeChange_HostGroupList
  https://reviews.apache.org/media/uploaded/files/2017/05/23/190f83cb-ce1b-4413-a9b3-cd988cd29133__AfterCodeChange_HostGroupList.png
AfterCodeChange_ManageHostGroupPage
  https://reviews.apache.org/media/uploaded/files/2017/05/23/1bb710b5-f5c3-482b-8dca-dd3950ec2fbb__AfterCodeChange_ManageHostGroupPage.png


Thanks,

Amruta Borkar