[GitHub] sdedic commented on a change in pull request #610: [NetBeans-1007] Convert all path separators to slashes (on all OS)

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #610: [NetBeans-1007] Convert all path separators to slashes (on all OS)
URL: https://github.com/apache/incubator-netbeans/pull/610#discussion_r202939713
 
 

 ##########
 File path: nbbuild/build.xml
 ##########
 @@ -1592,8 +1592,11 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d
             includes="${allmodules},${harness-modules},nbbuild${build.source.config.add.ide},nbi,libs.antlr3.devel,libs.junit4"
             excludes="nbi/engine/lib,nbi/infra/build/jvm,nbi/infra/sandbox,nbi/infra/server,nbi/infra/utils"
     />
-    <pathconvert property="source.dirs" pathsep="," refid="source.dirset">
-      <regexpmapper from="${nb_all}/(.*)$" to="\1/**/*" handledirsep="yes"/>
+    <pathconvert property="nb_all_slash" dirsep="/">
+      <path location="${nb_all}"/>
+    </pathconvert>
+    <pathconvert property="source.dirs" dirsep="/" pathsep="," refid="source.dirset">
+      <regexpmapper from="${nb_all_slash}/(.*)$" to="\1/**/*" handledirsep="yes"/>
 
 Review comment:
   Given that the `${nb_all}` value is (should be) apparently used as literal, wouldn't it be easier to just quote it in the regexp ? Also consider to use `${file.separator}` instead of `/`. E.g. `from="\Q${nb_slash}${file.separator}\E(.*)$"`
   
   (warning: didn't try on Windows yet, just OTOH)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists