You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/04 17:35:19 UTC

[GitHub] [incubator-tvm] tqchen opened a new pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

tqchen opened a new pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730


   We use a single enum(TypeCode) to represent ArgTypeCode and DLDataTypeCode.
   However, as we start to expand more data types, it is clear that argument
   type code(in the FFI convention) and data type code needs to evolve separately.
   So that we can add first class for data types without having changing the FFI ABI.
   
   This PR makes the distinction clear and refactored the code to separate the two.
   
   - [PY] Separate ArgTypeCode from DataTypeCode
   - [WEB] Separate ArgTypeCode from DataTypeCode
   - [JAVA] Separate ArgTypeCode from DataTypeCode
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639018766


   Will take a look tonight! Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639567636


   The kDLInt, kDLUInt, kDLFloat are still kept consistent with the original ArgType code. So downstream projects won't be affected. 
   
   It will only affect type code after kDLHandle


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639564805


   I see....looks like this might affect downstream projects too because kDLInt are not encouraged any more


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639143025


   @zhiics Yes the DLPack changes are needed for the followup PRs to use bfloat16


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-640100020


   #5742


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639568074


   @junrushao1994 we can also send a PR to add the comment about the consistency


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639605616


   Sure
   
   On Fri, Jun 5, 2020 at 08:33 Tianqi Chen <no...@github.com> wrote:
   
   > @junrushao1994 <https://github.com/junrushao1994> we can also send a PR
   > to add the comment about the consistency
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639568074>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AFLZBJJ7ZBVNDTS4BLBZZV3RVEF43ANCNFSM4NS2ZINQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639000274


   cc @zhiics @yzhliu @jroesch @junrushao1994 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org