You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/18 22:02:29 UTC

[GitHub] [logging-log4j2] jvz commented on a change in pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

jvz commented on a change in pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491213545



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java
##########
@@ -345,14 +355,17 @@ public static HtmlLayout createLayout(
             @PluginAttribute String contentType,
             @PluginAttribute(defaultString = "UTF-8") final Charset charset,
             @PluginAttribute String fontSize,
-            @PluginAttribute(value = "fontName", defaultString = DEFAULT_FONT_FAMILY) final String font) {
+            @PluginAttribute(value = "fontName", defaultString = DEFAULT_FONT_FAMILY) final String font,

Review comment:
       This factory method isn't needed anymore since the builder class is present.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org