You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/07/31 10:11:59 UTC
[GitHub] flink pull request #4424: [FLINK-7302] [table] Fix failed to run CorrelateIT...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4424
[FLINK-7302] [table] Fix failed to run CorrelateITCase class under wi…
With an environment on Windows, Test run failed as reference to UserDefinedFunctionTestUtils is ambiguous;
it is imported twice in the same scope by ```import org.apache.flink.table.utils._``` and ```import org.apache.flink.table.runtime.utils._```
Both happened on stream and batch package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-7302-CorrelateITCase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4424
----
commit 1e1ef0ed5fa8350c6e251df7ca4efa194ea2bbf7
Author: zhangminglei <zm...@163.com>
Date: 2017-07-31T10:01:13Z
[FLINK-7302] [table] Fix failed to run CorrelateITCase class under windows environment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4424
Also, please fill out the pull request form the next time you open a PR. See PR #4444 as an example.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4424
Hi @zhangminglei, are you sure that this is not an issue with your local setup?
In the master branch, there is only one class `UserDefinedFunctionTestUtils` in org.apache.flink.table.runtime.utils`. It was previously located in `org.apache.flink.table.utils._` (and still is in the `release-1.3` branch) but was recently moved to the new location. Maybe something went wrong when you updated or switched your branch.
Can you clone a new copy of the master branch and try to build it?
I'm not opposed to the change you are proposing. I'd just like to understand the cause of the problem.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4424
There is nothing wrong with the newest code and test passed. I will close this PR and the correspoding JIRA soon. Thanks to @fhueske the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4424
@fhueske Thank you for your reply. Yes, I am always on the newest master branch every time I write code. What you said about causes that issue reason, it is did defined in ```org.apache.flink.table.utils._```. **But** the error is that ```UserDefinedFunctionTestUtils``` imports twice in the same scope. If we drop ```_``` and import specific class, we can get rid of this error. In ```import org.apache.flink.table.utils._``` package, there is a class called ```UserDefinedFunctionTestUtils``` and aslo in ```org.apache.flink.table.runtime.utils```, there is an object called ```UserDefinedFunctionTestUtils```. So, that is directly leading to the compiler can not distinguish which one we want to choose.
BTW, I dont down what the reaction to this on Linux or Mac. I can not afford a Mac, so I think i can found this error. Lol.
Yes. Recenly, I also found it seems that we have a new review code way like #4444 . OKay. I will follow the rule next time opening a PR.
Thanks again,
Minglei.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4424
Hi @zhangminglei, thanks for the PR. The changes look OK.
However, I don't understand what causes the problem `UserDefinedFunctionTestUtils` is not defined in `org.apache.flink.table.utils._`. Are you on the latest `master` branch?
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4424
Hey. @fhueske I checked my code again and found it build error i think. because it is really gives me the wrong error. You are right. I have decided that I have not build flink project for a long time. So, I guess that is the main reason leading to that issue. But in order to make sure it is correct. I will rebuild my flink project and run the test again. If there is no error i get. I will close this PR and the corresponing JIRA. But I will do a prediction, there isnt any error i will get ~ Waiting for this.
Thanks, Minglei
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4424: [FLINK-7302] [table] Fix failed to run CorrelateIT...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/4424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4424
Because build flink always cost me a lot of time, So, I wasnt did this build flink stuff often.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4424
Thanks for checking @zhangminglei!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---