You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/09/21 19:58:39 UTC

[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1294#discussion_r140344024
  
    --- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java ---
    @@ -154,7 +154,10 @@ protected static ExecutorService createInvokerPool(Args options) {
     
         return invoker;
       }
    -
    +  
    +  protected ExecutorService getInvoker() {
    --- End diff --
    
    This could probably be static, given the method above is also static?  Thoughts?


---