[GitHub] [arrow-datafusion] sarutak commented on a diff in pull request #7252: Avoid to use TempDir::into_path for temporary dirs expected to be deleted automatically

["sarutak (via GitHub)" <gi...@apache.org>]

sarutak commented on code in PR #7252:
URL: https://github.com/apache/arrow-datafusion/pull/7252#discussion_r1289330200


##########
datafusion/core/src/test/mod.rs:
##########
@@ -102,11 +105,10 @@ pub fn partitioned_file_groups(
     partitions: usize,
     file_type: FileType,
     file_compression_type: FileCompressionType,
+    work_dir: &Path,

Review Comment:
   are Temporary directories created by `TempDir::new` are deleted in `TempDir::drop`.
   But files created in the temporary directory can be refered by callers of this method, so we can't call `TempDir::new` in this method.
   The life cycle of such temporary directories should be managed by callers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org