You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/03/01 18:32:13 UTC
Review Request 65869: Removed unnecessary warning in agent
`statusUpdate()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65869/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Greg Mann.
Repository: mesos
Description
-------
If the task status update is generated by the agent
before the executor creation (e.g. due to task authorization
or unschedule GC failure), this "could not find executor"
warning will be triggered. But this is expected.
Diffs
-----
src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
Diff: https://reviews.apache.org/r/65869/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 65869: Removed unnecessary warning in agent
`statusUpdate()`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65869/#review198475
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65679, 65869]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2018, 6:32 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65869/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 6:32 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task status update is generated by the agent
> before the executor creation (e.g. due to task authorization
> or unschedule GC failure), this "could not find executor"
> warning will be triggered. But this is expected.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
>
>
> Diff: https://reviews.apache.org/r/65869/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65869: Removed unnecessary warning in agent
`statusUpdate()`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65869/#review213296
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65869]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2018, 6:32 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65869/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 6:32 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task status update is generated by the agent
> before the executor creation (e.g. due to task authorization
> or unschedule GC failure), this "could not find executor"
> warning will be triggered. But this is expected.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
>
>
> Diff: https://reviews.apache.org/r/65869/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65869: Removed unnecessary warning in agent
`statusUpdate()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65869/#review198467
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65679', '65869']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65869
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65869/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (123 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1151 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (44 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2496 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2522 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2473 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2498 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (486104 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65869/logs/mesos-tests-stderr.log):
```
I0301 20:23:42.865205 7096 master.cpp:10258] Updating the state of task 70f6128e-de3d-4ee4-9044-aab88d13ec7e of framework f6582520-4ec6-4db0-a950-71d264a5995d-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0301 20:23:42.865205 3344 slave.cpp:3879] Shutting down framework f6582520-4ec6-4db0-a950-71d264a5995d-0000
I0301 20:23:42.865205 3344 slave.cpp:6584] Shutting down executor '7I0301 20:23:42.163199 6344 exec.cpp:162] Version: 1.6.0
I0301 20:23:42.191201 10352 exec.cpp:236] Executor registered on agent f6582520-4ec6-4db0-a950-71d264a5995d-S0
I0301 20:23:42.196173 10860 executor.cpp:176] Received SUBSCRIBED event
I0301 20:23:42.200199 10860 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0301 20:23:42.201202 10860 executor.cpp:176] Received LAUNCH event
I0301 20:23:42.206202 10860 executor.cpp:648] Starting task 70f6128e-de3d-4ee4-9044-aab88d13ec7e
I0301 20:23:42.287200 10860 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0301 20:23:42.825179 10860 executor.cpp:661] Forked command at 9992
I0301 20:23:42.869204 8096 exec.cpp:445] Executor asked to shutdown
I0301 20:23:42.869204 10860 executor.cpp:176] Received SHUTDOWN event
I0301 20:23:42.870178 10860 executor.cpp:758] Shutting down
I0301 20:23:42.870178 10860 executor.cpp:868] Sending SIGTERM to process tree at pid 90f6128e-de3d-4ee4-9044-aab88d13ec7e' of framework f6582520-4ec6-4db0-a950-71d264a5995d-0000 at executor(1)@10.3.1.5:49266
I0301 20:23:42.867203 3344 slave.cpp:922] Agent terminating
W0301 20:23:42.868202 3344 slave.cpp:3875] Ignoring shutdown framework f6582520-4ec6-4db0-a950-71d264a5995d-0000 because it is terminating
I0301 20:23:42.868202 7096 master.cpp:10357] Removing task 70f6128e-de3d-4ee4-9044-aab88d13ec7e with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f6582520-4ec6-4db0-a950-71d264a5995d-0000 on agent f6582520-4ec6-4db0-a950-71d264a5995d-S0 at slave(398)@10.3.1.5:49244 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:23:42.870178 7096 master.cpp:1306] Agent f6582520-4ec6-4db0-a950-71d264a5995d-S0 at slave(398)@10.3.1.5:49244 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0301 20:23:42.870178 7096 master.cpp:3276] Disconnecting agent f6582520-4ec6-4db0-a950-71d264a5995d-S0 at slave(398)@10.3.1.5:49244 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:23:42.871181 9272 hierarchical.cpp:344] Removed framework f6582520-4ec6-4db0-a950-71d264a5995d-0000
I0301 20:23:42.871181 8028 containerizer.cpp:2338] Destroying container 256dbc26-a591-46f4-9c83-d8c9d9b8d44f in RUNNING state
I0301 20:23:42.872179 8028 containerizer.cpp:2952] Transitioning the state of container 256dbc26-a591-46f4-9c83-d8c9d9b8d44f from RUNNING to DESTROYING
I0301 20:23:42.872179 7096 master.cpp:3295] Deactivating agent f6582520-4ec6-4db0-a950-71d264a5995d-S0 at slave(398)@10.3.1.5:49244 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:23:42.872179 10532 hierarchical.cpp:766] Agent f6582520-4ec6-4db0-a950-71d264a5995d-S0 deactivated
I0301 20:23:42.873181 8028 launcher.cpp:156] Asked to destroy container 256dbc26-a591-46f4-9c83-d8c9d9b8d44f
I0301 20:23:42.957325 10532 containerizer.cpp:2791] Container 256dbc26-a591-46f4-9c83-d8c9d9b8d44f has exited
I0301 20:23:42.989326 9556 master.cpp:1149] Master terminating
I0301 20:23:42.992347 9272 hierarchical.cpp:609] Removed agent f6582520-4ec6-4db0-a950-71d264a5995d-S0
I0301 20:23:43.614377 5412 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 1, 2018, 6:32 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65869/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 6:32 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task status update is generated by the agent
> before the executor creation (e.g. due to task authorization
> or unschedule GC failure), this "could not find executor"
> warning will be triggered. But this is expected.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
>
>
> Diff: https://reviews.apache.org/r/65869/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65869: Removed unnecessary warning in agent
`statusUpdate()`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65869/#review213295
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65869]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 2, 2018, 2:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65869/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 2:32 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task status update is generated by the agent
> before the executor creation (e.g. due to task authorization
> or unschedule GC failure), this "could not find executor"
> warning will be triggered. But this is expected.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
>
>
> Diff: https://reviews.apache.org/r/65869/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65869: Removed unnecessary warning in agent
`statusUpdate()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65869/#review199457
-----------------------------------------------------------
PASS: Mesos patch 65869 was successfully built and tested.
Reviews applied: `['65869']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65869
- Mesos Reviewbot Windows
On March 1, 2018, 10:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65869/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 10:32 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task status update is generated by the agent
> before the executor creation (e.g. due to task authorization
> or unschedule GC failure), this "could not find executor"
> warning will be triggered. But this is expected.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
>
>
> Diff: https://reviews.apache.org/r/65869/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>